cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject [16/51] [abbrv] git commit: updated refs/heads/4.9-bountycastle-daan to d8c42a9
Date Wed, 18 May 2016 11:46:41 GMT
Merge pull request #1528 from mike-tutkowski/marvin_methods

CLOUDSTACK-9373: Class methods over-shawdowing instance methodsWe have some methods in base.py
that are named the same.

Per my findings below, Python methods in a class should not be named the same even if one
is a class method and the other is an instance method.

The solution discussed on dev@ is to remove the instance versions (reason listed in e-mail
text, which is listed in JIRA ticket).

https://issues.apache.org/jira/browse/CLOUDSTACK-9373

* pr/1528:
  CLOUDSTACK-9373: Removing a few instance methods where there are class methods that are
overshadowing them

Signed-off-by: Will Stevens <williamstevens@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/c79affae
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/c79affae
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/c79affae

Branch: refs/heads/4.9-bountycastle-daan
Commit: c79affaefb674a38c18ea008d4e1fb384b1ec6ca
Parents: 7e41747 1ad0da0
Author: Will Stevens <williamstevens@gmail.com>
Authored: Thu May 12 11:08:53 2016 -0400
Committer: Will Stevens <williamstevens@gmail.com>
Committed: Thu May 12 11:08:53 2016 -0400

----------------------------------------------------------------------
 tools/marvin/marvin/lib/base.py | 21 ---------------------
 1 file changed, 21 deletions(-)
----------------------------------------------------------------------



Mime
View raw message