cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sw...@apache.org
Subject [3/3] git commit: updated refs/heads/master to 7ce0e10
Date Wed, 04 May 2016 14:31:30 GMT
Merge pull request #1493 from shapeblue/nio-fix

CLOUDSTACK-9348: Use non-blocking SSL handshake in NioConnection/Link- Uses non-blocking socket
config in NioClient and NioServer/NioConnection
- Scalable connectivity from agents and peer clustered-management server
- Removes blocking ssl handshake code with a non-blocking code
- Protects from denial-of-service issues that can degrade mgmt server responsiveness
  due to an aggressive/malicious client
- Uses separate executor services for handling connect/accept events

Changes are covered the NioTest so I did not write a new test, advise how we can improve this.
Further, I tried to invest time on writing a benchmark test to reproduce a degraded server
but could not write it deterministic-ally (sometimes fails/passes but not always). Review,
CI testing and feedback requested /cc @swill @jburwell @DaanHoogland @wido @remibergsma @rafaelweingartner
@GabrielBrascher

* pr/1493:
  CLOUDSTACK-9348: Use non-blocking SSL handshake
  CLOUDSTACK-9348: Unit test to demonstrate denial of service attack

Signed-off-by: Will Stevens <williamstevens@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/7ce0e10f
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/7ce0e10f
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/7ce0e10f

Branch: refs/heads/master
Commit: 7ce0e10fbcd949375e43535aae168421ecdaa562
Parents: 29ba71f ba77a69
Author: Will Stevens <williamstevens@gmail.com>
Authored: Wed May 4 10:30:58 2016 -0400
Committer: Will Stevens <williamstevens@gmail.com>
Committed: Wed May 4 10:30:58 2016 -0400

----------------------------------------------------------------------
 .../manager/ClusteredAgentManagerImpl.java      |   9 +-
 utils/pom.xml                                   |   1 -
 .../src/main/java/com/cloud/utils/nio/Link.java | 294 ++++++++++++-------
 .../java/com/cloud/utils/nio/NioClient.java     |  31 +-
 .../java/com/cloud/utils/nio/NioConnection.java |  84 +++---
 .../java/com/cloud/utils/nio/NioServer.java     |   8 +-
 .../java/com/cloud/utils/testcase/NioTest.java  | 249 ++++++++++------
 7 files changed, 406 insertions(+), 270 deletions(-)
----------------------------------------------------------------------



Mime
View raw message