cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhais...@apache.org
Subject [01/50] [abbrv] git commit: updated refs/heads/4.9-bountycastle-daan to 4817cb6 [Forced Update!]
Date Wed, 11 May 2016 09:42:49 GMT
Repository: cloudstack
Updated Branches:
  refs/heads/4.9-bountycastle-daan 68217c226 -> 4817cb6ab (forced update)


Merge pull request #1485 from remibergsma/fix-ldap-default-domain

Set default networkDomain to empty instead of usernameThe 10th field of `createUserAccount`
is `networkDomain` (See `AccountService.java`) and it is set to a var named `admin`, which
is the user name.
So, the first user that is created in a domain that links to LDAP, creates the account within
the domain, and sets the `networkDomain` field to the username. All next users are created
in the same account.

Then we have the situation that in domain SBP we have a user `rbergsma` that logs in first,
gets an account created and then (unless you override) all VMs started in the SBP domain will
have network domain `rbergsma`. That is highly confusing and not what is should be.

The `linkDomainToLdap` api call has no `networkDomain` field, so I propose to make this field
empty (set it to null). It's a sting and null / empty is allowed.

One can also specify the networkDomain when creating a VPC and also there it is allowed to
be null.

When te networkDomain is needed (and is not set in the domain and not in the VPC) it is constructed
by using `guest.domain.suffix` so there always is a networkDomain to be used.

It makes more sense to manually set it on a domain level, or specify it on the VPC and in
the final case end up with something that is clearly generated (like cs342cloud.local) rather
than the username of someone else.

* pr/1485:
  Set default networkDomain to empty instead of username

Signed-off-by: Will Stevens <williamstevens@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f434f50a
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f434f50a
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f434f50a

Branch: refs/heads/4.9-bountycastle-daan
Commit: f434f50a86c19ed434aea44975e2120689c2b4b6
Parents: 987e800 9e1859e
Author: Will Stevens <williamstevens@gmail.com>
Authored: Wed May 4 10:19:58 2016 -0400
Committer: Will Stevens <williamstevens@gmail.com>
Committed: Wed May 4 10:19:58 2016 -0400

----------------------------------------------------------------------
 .../src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java | 2 +-
 .../ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------



Mime
View raw message