cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [2/3] git commit: updated refs/heads/4.8 to 713c2f5
Date Mon, 11 Apr 2016 12:41:46 GMT
Merge pull request #1441 from mike-tutkowski/4.7

CLOUDSTACK-9297 - Reworked logic in StorageSystemSnapshotStrategy and XenserverSnapshotStrategyThe
ticket this PR fixes was opened because KVM-specific code had been added to the StorageSystemSnapshotStrategy
class and that class' canHandle method was only prepared to handle managed storage being used
with XenServer (and a case was hit for KVM that triggered a CloudRuntimeException to be thrown).

To solve the problem, I moved the KVM logic to the default snapshot strategy class, which
is (unfortunately) named XenserverSnapshotStrategy.

I plan to rename XenserverSnapshotStrategy to something like DefaultSnapshotStrategy in 4.9.

My guess is that when XenserverSnapshotStrategy was originally written, it was written only
for XenServer, but has since that time had its usage increased to support other hypervisors
(with non-managed storage).

* pr/1441:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to determine the storage
pool of the snapshot

Signed-off-by: Will Stevens <>


Branch: refs/heads/4.8
Commit: f33b4a1b687775e435baf292d9d49c0f0a418538
Parents: ef115ab 158d196
Author: Will Stevens <>
Authored: Mon Apr 11 08:40:17 2016 -0400
Committer: Will Stevens <>
Committed: Mon Apr 11 08:40:17 2016 -0400

 .../snapshot/ | 79 ++++----------------
 .../snapshot/     | 59 ++++++++++++++-
 2 files changed, 70 insertions(+), 68 deletions(-)

View raw message