Return-Path: X-Original-To: apmail-cloudstack-commits-archive@www.apache.org Delivered-To: apmail-cloudstack-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4238918A39 for ; Sat, 16 Jan 2016 18:55:12 +0000 (UTC) Received: (qmail 41918 invoked by uid 500); 16 Jan 2016 18:55:09 -0000 Delivered-To: apmail-cloudstack-commits-archive@cloudstack.apache.org Received: (qmail 41859 invoked by uid 500); 16 Jan 2016 18:55:09 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 40200 invoked by uid 99); 16 Jan 2016 18:55:08 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Jan 2016 18:55:08 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7D2F6E3868; Sat, 16 Jan 2016 18:55:08 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: remi@apache.org To: commits@cloudstack.apache.org Date: Sat, 16 Jan 2016 18:55:29 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [22/28] git commit: updated refs/heads/master to 75b68c6 Merge pull request #1300 from nitin-maharana/CloudStack-Nitin10_4.7 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failingReproducible Steps: ================ 1.Create a customer gateway for a VPC. 2.Edit it using UI(API call is UpdateVpnCustomerGateway). 3.When we try to update the customer vpn gateway with connection state is not in "Error", we see the API error but that won't be reflected to the user in UI. Actual Behaviour: ============== The API throws error. But UI doesn't show it to user. Expected Behaviour: ================ The UI should show the error to user. Fix: === TypeError: json.updatecustomergatewayresponse is undefined The response name was wrong so corrected it. It should be json.updatevpncustomergatewayresponse. Added the error function. * pr/1300: CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing Signed-off-by: Remi Bergsma Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/146a6fd3 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/146a6fd3 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/146a6fd3 Branch: refs/heads/master Commit: 146a6fd3ec9e94dd0715e43a72d9f780d7763b04 Parents: 1b5c645 116b2b6 Author: Remi Bergsma Authored: Sat Jan 16 19:41:04 2016 +0100 Committer: Remi Bergsma Committed: Sat Jan 16 19:41:04 2016 +0100 ---------------------------------------------------------------------- ui/scripts/network.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/146a6fd3/ui/scripts/network.js ----------------------------------------------------------------------