cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r...@apache.org
Subject [2/2] git commit: updated refs/heads/master to 6d558c0
Date Thu, 03 Dec 2015 09:13:08 GMT
Merge pull request #944 from rafaelweingartner/lrg-cs-hackday-012

Create test cases to getPatchFilePath method and class names changed In this commit we created
tests cases for the respective classes in package  com.cloud.hypervisor.xenserver.resource.

We added test cases to check the implementation of  com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.getPatchFiles.
Therefore, we test in a more comprehensive way the tests that already exist to check the code
of com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.getPatchFilePath.

We added a new abstract class, called com.cloud.hypervisor.xenserver.resource.CitrixResourceBaseTest.java

This class has two tests methods:

* com.cloud.hypervisor.xenserver.resource.CitrixResourceBaseTest.testGetPathFilesExeption(CitrixResourceBase),
this method tests if the getPatchFilePath() method throws the com.cloud.utils.exception.CloudRuntimeException.CloudRuntimeException
when the com.cloud.utils.script.Script.findScript(String, String) return a null value;
* com.cloud.hypervisor.xenserver.resource.CitrixResourceBaseTest.testGetPathFilesListReturned(CitrixResourceBase),
this method tests the correct return value from getPatchFilePath() method, basically, verify
if the returned list contain the file with the same absolute path that was retrieved from
the findScript method.

We also changed the name of those test classes, the change was basically remove the Path word
from the name of classes.

* pr/944:
  created tests cases for method "citrixResourceBase.getPatchFiles"

Signed-off-by: Remi Bergsma <github@remi.nl>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/6d558c02
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/6d558c02
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/6d558c02

Branch: refs/heads/master
Commit: 6d558c0201980d6c04f8e7ad80e228556c293c93
Parents: 17d5bfa d01cdb1
Author: Remi Bergsma <github@remi.nl>
Authored: Thu Dec 3 10:12:07 2015 +0100
Committer: Remi Bergsma <github@remi.nl>
Committed: Thu Dec 3 10:12:07 2015 +0100

----------------------------------------------------------------------
 .../xenserver/resource/CitrixResourceBase.java  |  2 +-
 .../resource/CitrixResourceBaseTest.java        | 52 ++++++++++++++++++++
 .../resource/XcpOssResourcePathTest.java        | 32 ------------
 .../xenserver/resource/XcpOssResourceTest.java  | 50 +++++++++++++++++++
 .../resource/XcpServerResourcePathTest.java     | 32 ------------
 .../resource/XcpServerResourceTest.java         | 51 +++++++++++++++++++
 .../XenServer56FP1ResourcePathTest.java         | 32 ------------
 .../resource/XenServer56FP1ResourceTest.java    | 48 ++++++++++++++++++
 .../resource/XenServer56ResourcePathTest.java   | 32 ------------
 .../resource/XenServer56ResourceTest.java       | 49 ++++++++++++++++++
 .../XenServer56SP2ResourcePathTest.java         | 32 ------------
 .../resource/XenServer56SP2ResourceTest.java    | 48 ++++++++++++++++++
 .../resource/XenServer600ResourcePathTest.java  | 32 ------------
 .../resource/XenServer600ResourceTest.java      | 48 ++++++++++++++++++
 .../resource/XenServer625ResourcePathTest.java  | 32 ------------
 .../resource/XenServer625ResourceTest.java      | 48 ++++++++++++++++++
 .../resource/XenServer650ResourcePathTest.java  | 32 ------------
 .../resource/XenServer650ResourceTest.java      | 49 ++++++++++++++++++
 18 files changed, 444 insertions(+), 257 deletions(-)
----------------------------------------------------------------------



Mime
View raw message