cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [2/2] git commit: updated refs/heads/master to 186e025
Date Thu, 03 Dec 2015 09:28:29 GMT
Merge pull request #943 from rafaelweingartner/lrg-cs-hackday-009

CLOUDSTACK-8988: Removed unused adapters from async-job-component.xml.I was looking the file
/cloud-server/test/async-job-component.xml, and I found an adapter configuration that seems
to have no use. The reason for that is explained as follows.

The adapter configuration is the following:
<*adapters key=""*>
      <*adapter name="Storage"
        <*param name="storage.overprovisioning.factor"*>2<*/param*>
      <*adapter name="
        <*param name="storage.overprovisioning.factor"*>2<*/param*>


The class "" does not exist.
The only reference for it is found in the following file:
          -	/cloud-server/test/async-job-component.xml
Therefore, we can conclude that there is no need for this line at that file.


Additionally, the class is never used. The only reference
is found in the following file:
-	/cloud-server/test/async-job-component.xml

I found a project called cloud-plugin-storage-allocator-random. This project has only one
package that contains only one class, which is the Despite
the names that are the same, the class in cloud-plugin-storage-allocator-random  project and
the class referenced in -	/cloud-server/test/async-job-component.xml have different packages.
Therefore, I removed that configuration from async-job-component.xml and the project that
contains only the RandomStoragePoolAllocator class that is never used.
Consequently, I had to remove the following lines from the */cloud-client-ui/pom.xml*:

Furthermore, after I removed that configuration I noticed that there is no such class
However, it appears that exists test for it, like the following classes:

I am not sure if these classes are tests for the class and for the possible
configuration I have just removed. If they are, we can remove both classes. Can someone help
me on checking that?

* pr/943:
  fixed references in async-job-component.xml for storage allocators

Signed-off-by: Remi Bergsma <>


Branch: refs/heads/master
Commit: 186e0257c3c192723b56e03f1fee8f63eb14e7dd
Parents: 6d558c0 49f5a6b
Author: Remi Bergsma <>
Authored: Thu Dec 3 10:27:55 2015 +0100
Committer: Remi Bergsma <>
Committed: Thu Dec 3 10:27:55 2015 +0100

 server/test/async-job-component.xml | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

View raw message