cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r...@apache.org
Subject [2/2] git commit: updated refs/heads/master to bc5a5d6
Date Fri, 30 Oct 2015 11:41:12 GMT
Merge pull request #1006 from greenqloud/user_vm_keypairs_fix

Fixed user_vm_view to only display keypairs belonging to the account.The user_vm_view displayes
the keypair information by joining vm_details with ssh_keypairs on the key value exclusively.

We found a scenario in which this can cause information leakage. If there are two accounts
using the same key, but create a different key name for it, and then a vm is created using
one of the keys, the view will list both keypairs as belonging to the vm, which can in turn
cause confusion to the users who see a keypair name which they did not create.

The fix simply limits the view to displaying keypairs which belong to vm's account.

I added it to the latest schema migration only; should I also include it in the previous ones?

* pr/1006:
  CLOUDSTACK-9011 - Fixed user_vm_view to only display keypairs belonging to the account.

Signed-off-by: Remi Bergsma <github@remi.nl>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/bc5a5d66
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/bc5a5d66
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/bc5a5d66

Branch: refs/heads/master
Commit: bc5a5d662340030fe8f3182f4b3385682a890c47
Parents: af90caf 9191da3
Author: Remi Bergsma <github@remi.nl>
Authored: Fri Oct 30 12:40:43 2015 +0100
Committer: Remi Bergsma <github@remi.nl>
Committed: Fri Oct 30 12:40:43 2015 +0100

----------------------------------------------------------------------
 setup/db/db/schema-452to460.sql | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------



Mime
View raw message