cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From e...@apache.org
Subject [2/2] git commit: updated refs/heads/4.4 to b0a4593
Date Tue, 01 Sep 2015 11:28:20 GMT
Merge pull request #761 from remibergsma/fix-hyperv-returns

Have HyperV behave in 4.4 and return null instead of falseCommit 6a4927f660f776bcbd12ae45f4e63ae2c2e96774
made the HyperV investigator return false instead of null.

Returning false means the VM is NOT running, returning null means "I don't know". In 4.4 I
experienced corruption because of HyperV returning false, instead of null.

Tonight I experienced corruption when one of our management servers went down (out-of-memory,
not root caused yet). While all hypervisors that were connected to this management server
were connecting the other, HA work started as well with investigators. HyperV happily reported
everything as down (while it was still running), causing a mess.

In 4.5 and master this was already fixed. If you know a better way to fix this, please let
me know!
This may cause another FindBugs alert, not sure how to resolve that. I just want this out
ASAP. Maybe @DaanHoogland @wilderrodrigues or @miguelaferreira can advise on how to fix this
properly.

* pr/761:
  Have HyperV behave in 4.4 and return null instead of false

Signed-off-by: Wilder Rodrigues <wilder.rodrigues@ekholabs.nl>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/b0a45931
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/b0a45931
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/b0a45931

Branch: refs/heads/4.4
Commit: b0a45931527cb57e4d23edab36adf4fac1ffa494
Parents: 3b3d2fc 03929d2
Author: Wilder Rodrigues <wilder.rodrigues@ekholabs.nl>
Authored: Tue Sep 1 11:25:20 2015 +0000
Committer: Wilder Rodrigues <wilder.rodrigues@ekholabs.nl>
Committed: Tue Sep 1 11:25:20 2015 +0000

----------------------------------------------------------------------
 .../hypervisors/hyperv/src/com/cloud/ha/HypervInvestigator.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------



Mime
View raw message