Return-Path: X-Original-To: apmail-cloudstack-commits-archive@www.apache.org Delivered-To: apmail-cloudstack-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB0B918FCF for ; Wed, 19 Aug 2015 09:00:29 +0000 (UTC) Received: (qmail 15356 invoked by uid 500); 19 Aug 2015 09:00:29 -0000 Delivered-To: apmail-cloudstack-commits-archive@cloudstack.apache.org Received: (qmail 15321 invoked by uid 500); 19 Aug 2015 09:00:29 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 15312 invoked by uid 99); 19 Aug 2015 09:00:29 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2015 09:00:29 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 638C6E04DE; Wed, 19 Aug 2015 09:00:29 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: bhaisaab@apache.org To: commits@cloudstack.apache.org Message-Id: <6acf6872997b43eb974e46cdab908cc5@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: cloudstack-cloudmonkey git commit: Revert "Fix some parameters are double encoded" Date: Wed, 19 Aug 2015 09:00:29 +0000 (UTC) Repository: cloudstack-cloudmonkey Updated Branches: refs/heads/master 1bc53d203 -> 653dcca9e Revert "Fix some parameters are double encoded" This breaks API, api expects only single encoding. Tested against 4.5.1. ... "(UI uses javascript to encode on the fly, see ui/scripts/accounts.js:1852), such as registerSSHKeyPair/publickey. I did a quick search for other cases, bu there may be more parameters." This reverts commit 6bd92395592c133a63b8087bf4acc9cb3a1aac0d. Project: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/commit/653dcca9 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/tree/653dcca9 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/diff/653dcca9 Branch: refs/heads/master Commit: 653dcca9e008e20fee83f0b40f388611ad931d15 Parents: 1bc53d2 Author: Rohit Yadav Authored: Wed Aug 19 14:29:05 2015 +0530 Committer: Rohit Yadav Committed: Wed Aug 19 14:29:05 2015 +0530 ---------------------------------------------------------------------- cloudmonkey/requester.py | 3 --- 1 file changed, 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/blob/653dcca9/cloudmonkey/requester.py ---------------------------------------------------------------------- diff --git a/cloudmonkey/requester.py b/cloudmonkey/requester.py index a8f587b..d652948 100644 --- a/cloudmonkey/requester.py +++ b/cloudmonkey/requester.py @@ -189,9 +189,6 @@ def make_request(command, args, logger, url, credentials, expires, args[key] = value if not key: args.pop(key) - else: - if key in ['publickey', 'privatekey', 'certificate']: - args[key] = urllib.quote_plus(str(value)) # try to use the apikey/secretkey method by default # followed by trying to check if we're using integration port