cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r...@apache.org
Subject [2/2] git commit: updated refs/heads/master to 614ee49
Date Thu, 20 Aug 2015 09:42:44 GMT
Merge pull request #700 from rafaelweingartner/master-lrg-cs-hackday-001

Removed duplicate code in CitrixResourceBase and its subclassesRemoved unnecessary duplicated
code by having the body of the getPatchFiles method only in the CitrixResourceBase superclass.
Given that all of its implementations consisted of the same code except for the path which
contains the necessary file for that implementation. An abstract method getPatchFilePath was
created in the CitrixResourceBase superclass so that each implementation may return the path
containing the specific file needed by that implementation.

Test cases were created for each implementation, simple as they may be. One assert is made
to verify that the path returned by each implementation corresponds to the path that was previously
specified on each getPatchFiles implementation.

* pr/700:
  Removed duplicate code in CitrixResourceBase.getPatchFiles

Signed-off-by: Remi Bergsma <github@remi.nl>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/614ee494
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/614ee494
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/614ee494

Branch: refs/heads/master
Commit: 614ee494eec77d8373e4cdb3971a8d6b56611af2
Parents: 9229f35 ec8976f
Author: Remi Bergsma <github@remi.nl>
Authored: Thu Aug 20 11:20:00 2015 +0200
Committer: Remi Bergsma <github@remi.nl>
Committed: Thu Aug 20 11:20:00 2015 +0200

----------------------------------------------------------------------
 .../xenserver/resource/CitrixResourceBase.java  | 14 +++++++--
 .../xenserver/resource/XcpOssResource.java      | 19 ++----------
 .../xenserver/resource/XcpServerResource.java   | 18 ++---------
 .../resource/XenServer56FP1Resource.java        | 17 ++---------
 .../xenserver/resource/XenServer56Resource.java | 27 ++++-------------
 .../resource/XenServer56SP2Resource.java        | 19 ------------
 .../resource/XenServer600Resource.java          | 19 ++----------
 .../resource/XenServer650Resource.java          | 18 ++---------
 .../resource/Xenserver625Resource.java          | 22 +++-----------
 .../resource/XcpOssResourcePathTest.java        | 32 ++++++++++++++++++++
 .../resource/XcpServerResourcePathTest.java     | 32 ++++++++++++++++++++
 .../XenServer56FP1ResourcePathTest.java         | 32 ++++++++++++++++++++
 .../resource/XenServer56ResourcePathTest.java   | 32 ++++++++++++++++++++
 .../XenServer56SP2ResourcePathTest.java         | 32 ++++++++++++++++++++
 .../resource/XenServer600ResourcePathTest.java  | 32 ++++++++++++++++++++
 .../resource/XenServer625ResourcePathTest.java  | 32 ++++++++++++++++++++
 .../resource/XenServer650ResourcePathTest.java  | 32 ++++++++++++++++++++
 17 files changed, 288 insertions(+), 141 deletions(-)
----------------------------------------------------------------------



Mime
View raw message