cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject [04/13] git commit: updated refs/heads/master to d32d6a2
Date Mon, 03 Aug 2015 21:45:03 GMT
CLOUDSTACK-8656: removed unused input stream
  there was code to close a stream that was never created

Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/4e658457
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/4e658457
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/4e658457

Branch: refs/heads/master
Commit: 4e65845789643db29b4a1f1789bbb8e1b8e16859
Parents: 89bd6d0
Author: Daan Hoogland <daan@onecht.net>
Authored: Sun Aug 2 12:58:56 2015 +0200
Committer: Daan Hoogland <daan@onecht.net>
Committed: Sun Aug 2 12:58:56 2015 +0200

----------------------------------------------------------------------
 .../src/com/cloud/certificate/dao/CertificateDaoImpl.java | 10 ----------
 1 file changed, 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/4e658457/engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java
----------------------------------------------------------------------
diff --git a/engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java b/engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java
index a2ec67b..978fee0 100644
--- a/engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java
+++ b/engine/schema/src/com/cloud/certificate/dao/CertificateDaoImpl.java
@@ -16,9 +16,6 @@
 // under the License.
 package com.cloud.certificate.dao;
 
-import java.io.BufferedInputStream;
-import java.io.IOException;
-
 import javax.ejb.Local;
 
 import org.apache.log4j.Logger;
@@ -41,7 +38,6 @@ public class CertificateDaoImpl extends GenericDaoBase<CertificateVO,
Long> impl
 
     @Override
     public Long persistCustomCertToDb(String certStr, CertificateVO cert, Long managementServerId)
{
-        BufferedInputStream f = null;
         try {
             cert.setCertificate(certStr);
             cert.setUpdated("Y");
@@ -50,12 +46,6 @@ public class CertificateDaoImpl extends GenericDaoBase<CertificateVO,
Long> impl
         } catch (Exception e) {
             s_logger.warn("Unable to read the certificate: " + e);
             return new Long(0);
-        } finally {
-            if (f != null)
-                try {
-                    f.close();
-                } catch (IOException ignored) {
-                }
         }
     }
 }


Mime
View raw message