cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhais...@apache.org
Subject [1/2] git commit: updated refs/heads/master to 215a43d
Date Mon, 31 Aug 2015 08:58:49 GMT
Repository: cloudstack
Updated Branches:
  refs/heads/master 53cba7c74 -> 215a43dfa


CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing

Due to aggregation of templates and isos on the UI/client side, it could result
that for each page we could end up having lesser templates/isos listed to have
the scroll shown that triggers infinite scrolling. In theory, there
is still a chance if there are several zones with the same template being listed
resulting in only one aggregated template which could cause the scroll to not
get shown; but in practice I believe this fix should work for most users.

Page size set based on experimental data:
https://github.com/apache/cloudstack/pull/751#issuecomment-135661968

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a6e8cfde
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a6e8cfde
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a6e8cfde

Branch: refs/heads/master
Commit: a6e8cfde3f3049a7a68c049a45ce225b9f47e178
Parents: 8221ebd
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Authored: Thu Aug 27 12:31:04 2015 +0530
Committer: Rohit Yadav <rohit.yadav@shapeblue.com>
Committed: Fri Aug 28 13:07:47 2015 +0530

----------------------------------------------------------------------
 ui/scripts/templates.js | 8 ++++++++
 1 file changed, 8 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a6e8cfde/ui/scripts/templates.js
----------------------------------------------------------------------
diff --git a/ui/scripts/templates.js b/ui/scripts/templates.js
index 48f06fd..ac739c6 100644
--- a/ui/scripts/templates.js
+++ b/ui/scripts/templates.js
@@ -879,6 +879,10 @@
                     dataProvider: function(args) {
                         var data = {};
                         listViewDataProvider(args, data);
+                        // Due to zonal grouping, low pagesize can result lower
+                        // aggregated items, resulting in no scroll shown
+                        // So, use maximum pagesize
+                        data.pagesize = 200;
 
                         var ignoreProject = false;
                         if (args.filterBy != null) { //filter dropdown
@@ -2024,6 +2028,10 @@
                     dataProvider: function(args) {
                         var data = {};
                         listViewDataProvider(args, data);
+                        // Due to zonal grouping, low pagesize can result lower
+                        // aggregated items, resulting in no scroll shown
+                        // So, use maximum pagesize
+                        data.pagesize = 200;
 
                         var ignoreProject = false;
                         if (args.filterBy != null) { //filter dropdown


Mime
View raw message