cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhais...@apache.org
Subject [2/2] git commit: updated refs/heads/master to e2a0d18
Date Wed, 26 Aug 2015 10:30:55 GMT
Merge pull request #696 from iwebhosting/rbd-live-resize

Default to notify only script to handle non-CLVM/QCOW cases.This relates to [CLOUDSTACK-8732](https://issues.apache.org/jira/browse/CLOUDSTACK-8732)

Before this commit the call to `getResizeScriptType` would throw an exception (earlier versions
returned `null`, which was fine) - this caused the RBD case to fail. By changing the default
to notify only we fix the case for any non-CLVM and non-QCOW cases, too.

This is RBD for now, but this should extend to new storage types supported by Libvirt natively
in future.

This is my first attempted contribution: I can see a case for adding RBD logic to the actual
getResizeScriptType call, too, but I felt that putting it `LibvirtResizeVolumeCommandWrapper.java`
kept the special-casing of RBD (and comments about that) in one place.

### Caveat:

With Libvirt 1.2.2 this actually doesn't do the right thing - but it does do what the documentation
*says* should be the right thing, so I'm going to test if this is a Libvirt bug which is fixed
in a later version.

(To make it work I need to execute something like:

    virsh blockresize --path vda --size 100G i-7-44-VM

where vda is the path as far as the *guest* is concerned, and not an `rbd/` path - which *should*
work, but doesn't.)

* pr/696:
  Default to notify only script to handle non-CLVM/QCOW cases.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/e2a0d18a
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/e2a0d18a
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/e2a0d18a

Branch: refs/heads/master
Commit: e2a0d18a84c03593c64176b214cb805806f4d37d
Parents: 46a5f4b 77a96ed
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Authored: Wed Aug 26 16:00:01 2015 +0530
Committer: Rohit Yadav <rohit.yadav@shapeblue.com>
Committed: Wed Aug 26 16:00:01 2015 +0530

----------------------------------------------------------------------
 .../kvm/resource/wrapper/LibvirtResizeVolumeCommandWrapper.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------



Mime
View raw message