cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject [2/3] git commit: updated refs/heads/master to a1ff7e2
Date Tue, 14 Jul 2015 11:41:30 GMT
coverity 1311708: sql exception caught instead of generic (runtime)

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/3c125c0d
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/3c125c0d
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/3c125c0d

Branch: refs/heads/master
Commit: 3c125c0dc10598590694a85ea8d4a3533ba2638c
Parents: e62d952
Author: Daan Hoogland <daan@onecht.net>
Authored: Tue Jul 14 10:45:19 2015 +0200
Committer: Daan Hoogland <daan.hoogland@gmail.com>
Committed: Tue Jul 14 13:41:09 2015 +0200

----------------------------------------------------------------------
 engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/3c125c0d/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
----------------------------------------------------------------------
diff --git a/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java b/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
index 2c68210..db028c4 100644
--- a/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
+++ b/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
@@ -654,11 +654,8 @@ public class UserVmDaoImpl extends GenericDaoBase<UserVmVO, Long>
implements Use
                             rs.getString("vm_instance.instance_name"), VirtualMachine.Type.valueOf(rs.getString("vm_type"))),
                             new Pair<Long, String>(rs.getLong("vm_instance.id"), rs.getString("user_vm_details.value"))));
                 }
-            } catch (Exception e) {
-                s_logger.error("GetVmsDetailsByNames: Exception: " + e.getMessage());
-                throw new CloudRuntimeException("GetVmsDetailsByNames: Exception: " + e.getMessage());
             }
-        } catch (Exception e) {
+        } catch (SQLException e) {
             s_logger.error("GetVmsDetailsByNames: Exception in sql: " + e.getMessage());
             throw new CloudRuntimeException("GetVmsDetailsByNames: Exception: " + e.getMessage());
         }


Mime
View raw message