Return-Path: X-Original-To: apmail-cloudstack-commits-archive@www.apache.org Delivered-To: apmail-cloudstack-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A5631783A for ; Mon, 22 Jun 2015 08:49:05 +0000 (UTC) Received: (qmail 89274 invoked by uid 500); 22 Jun 2015 08:49:05 -0000 Delivered-To: apmail-cloudstack-commits-archive@cloudstack.apache.org Received: (qmail 89245 invoked by uid 500); 22 Jun 2015 08:49:05 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 89236 invoked by uid 99); 22 Jun 2015 08:49:04 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jun 2015 08:49:04 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B0330DFD63; Mon, 22 Jun 2015 08:49:04 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: dahn@apache.org To: commits@cloudstack.apache.org Message-Id: <74a7e5d46ffb456a84a2cf6d4e8a6668@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: git commit: updated refs/heads/master to f038a74 Date: Mon, 22 Jun 2015 08:49:04 +0000 (UTC) Repository: cloudstack Updated Branches: refs/heads/master dc40f6117 -> f038a740a Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java Signed-off-by: Daan Hoogland This closes #499 Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f038a740 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f038a740 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f038a740 Branch: refs/heads/master Commit: f038a740a5d1518a5757be0cd7bb367eef4ad190 Parents: dc40f61 Author: Rafael da Fonseca Authored: Mon Jun 22 00:09:40 2015 +0200 Committer: Daan Hoogland Committed: Mon Jun 22 10:48:49 2015 +0200 ---------------------------------------------------------------------- engine/schema/src/com/cloud/upgrade/dao/Upgrade218to22.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f038a740/engine/schema/src/com/cloud/upgrade/dao/Upgrade218to22.java ---------------------------------------------------------------------- diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade218to22.java b/engine/schema/src/com/cloud/upgrade/dao/Upgrade218to22.java index 62b3605..d3d10d9 100644 --- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade218to22.java +++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade218to22.java @@ -1286,8 +1286,8 @@ public class Upgrade218to22 implements DbUpgrade { pstmt.setLong(1, id); pstmt.setLong(2, instanceId); pstmt.setString(3, privateIp); - pstmt.setInt(4, Integer.valueOf(privatePort.trim())); - pstmt.setInt(5, Integer.valueOf(privatePort.trim())); + pstmt.setInt(4, Integer.parseInt(privatePort.trim())); + pstmt.setInt(5, Integer.parseInt(privatePort.trim())); pstmt.executeUpdate(); pstmt.close(); s_logger.trace("port_forwarding_rules table is updated");