Return-Path: X-Original-To: apmail-cloudstack-commits-archive@www.apache.org Delivered-To: apmail-cloudstack-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C9BAB18AB6 for ; Fri, 19 Jun 2015 22:58:11 +0000 (UTC) Received: (qmail 99721 invoked by uid 500); 19 Jun 2015 22:58:06 -0000 Delivered-To: apmail-cloudstack-commits-archive@cloudstack.apache.org Received: (qmail 99682 invoked by uid 500); 19 Jun 2015 22:58:06 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 99673 invoked by uid 99); 19 Jun 2015 22:58:06 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2015 22:58:06 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 91B15E04C9; Fri, 19 Jun 2015 22:58:06 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: dahn@apache.org To: commits@cloudstack.apache.org Message-Id: <30eada4951a54a4aa3e1703fc7379444@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: git commit: updated refs/heads/master to 9eff27a Date: Fri, 19 Jun 2015 22:58:06 +0000 (UTC) Repository: cloudstack Updated Branches: refs/heads/master 871ba9c52 -> 9eff27a08 findbugs: static member should be final Signed-off-by: Daan Hoogland This closes #495 Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/9eff27a0 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/9eff27a0 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/9eff27a0 Branch: refs/heads/master Commit: 9eff27a080f035aac44c7a716ff41efc2f233c64 Parents: 871ba9c Author: Daan Hoogland Authored: Sat Jun 20 00:03:06 2015 +0200 Committer: Daan Hoogland Committed: Sat Jun 20 00:57:59 2015 +0200 ---------------------------------------------------------------------- .../com/cloud/hypervisor/vmware/resource/VmwareResource.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/9eff27a0/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java ---------------------------------------------------------------------- diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java index 81bc025..5701ee9 100644 --- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java +++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java @@ -313,7 +313,7 @@ public class VmwareResource implements StoragePoolResource, ServerResource, Vmwa protected DiskControllerType _rootDiskController = DiskControllerType.ide; protected ManagedObjectReference _morHyperHost; - protected static ThreadLocal s_serviceContext = new ThreadLocal(); + protected final static ThreadLocal s_serviceContext = new ThreadLocal(); protected String _hostName; protected List _cmdMBeans = new ArrayList(); @@ -327,9 +327,8 @@ public class VmwareResource implements StoragePoolResource, ServerResource, Vmwa protected VirtualRoutingResource _vrResource; - protected static HashMap s_powerStatesTable; + protected final static HashMap s_powerStatesTable = new HashMap(); static { - s_powerStatesTable = new HashMap(); s_powerStatesTable.put(VirtualMachinePowerState.POWERED_ON, PowerState.PowerOn); s_powerStatesTable.put(VirtualMachinePowerState.POWERED_OFF, PowerState.PowerOff); s_powerStatesTable.put(VirtualMachinePowerState.SUSPENDED, PowerState.PowerOn);