cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From e...@apache.org
Subject [46/50] [abbrv] git commit: updated refs/heads/feature/vpc-ipv6 to 6140db5
Date Mon, 08 Jun 2015 09:46:07 GMT
Fix 3 more findbugs performance alerts, creating Long and Integer unnecessarily F5BigIpResource.java:297,
DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING,
Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing
to parse a primitive com.cloud.network.resource.F5BigIpResource

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #366


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/039d632a
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/039d632a
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/039d632a

Branch: refs/heads/feature/vpc-ipv6
Commit: 039d632ad3143dce5b39b0202092f0c6a6d09c44
Parents: e8c7069
Author: Rafael da Fonseca <rsafonseca@gmail.com>
Authored: Sun Jun 7 21:33:49 2015 +0200
Committer: Daan Hoogland <daan.hoogland@gmail.com>
Committed: Mon Jun 8 09:40:59 2015 +0200

----------------------------------------------------------------------
 .../f5/src/com/cloud/network/resource/F5BigIpResource.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/039d632a/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
----------------------------------------------------------------------
diff --git a/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
b/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
index 0f70a9b..c4e0fdf 100644
--- a/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
+++ b/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
@@ -294,7 +294,7 @@ public class F5BigIpResource implements ServerResource {
             for (IpAddressTO ip : ips) {
                 // is it saver to use Long.valueOf(BroadcastDomain.getValue(ip.getBroadcastUri()))
???
                 // i.o.w. can this contain vlan:// then change !!!
-                long guestVlanTag = Long.valueOf(ip.getBroadcastUri());
+                long guestVlanTag = Long.parseLong(ip.getBroadcastUri());
                 // It's a hack, using isOneToOneNat field for indicate if it's inline or
not
                 boolean inline = ip.isOneToOneNat();
                 String vlanSelfIp = inline ? tagAddressWithRouteDomain(ip.getVlanGateway(),
guestVlanTag) : ip.getVlanGateway();
@@ -700,7 +700,7 @@ public class F5BigIpResource implements ServerResource {
                 List<String> poolMembers = getMembers(virtualServerName);
                 for (String poolMember : poolMembers) {
                     String[] destIpAndPort = getIpAndPort(poolMember);
-                    deletePoolMember(virtualServerName, destIpAndPort[0], Integer.valueOf(destIpAndPort[1]));
+                    deletePoolMember(virtualServerName, destIpAndPort[0], Integer.parseInt(destIpAndPort[1]));
                 }
 
                 // Delete the virtual server
@@ -886,7 +886,7 @@ public class F5BigIpResource implements ServerResource {
         for (String member : allPoolMembers) {
             if (!activePoolMembers.contains(member)) {
                 String[] ipAndPort = member.split("-");
-                deletePoolMember(virtualServerName, ipAndPort[0], Integer.valueOf(ipAndPort[1]));
+                deletePoolMember(virtualServerName, ipAndPort[0], Integer.parseInt(ipAndPort[1]));
             }
         }
     }


Mime
View raw message