cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhais...@apache.org
Subject [4/4] git commit: updated refs/heads/master to 0f4aac7
Date Mon, 15 Jun 2015 09:18:21 GMT
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't
used in runtime, null is properly checked in method

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #444


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/0f4aac73
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/0f4aac73
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/0f4aac73

Branch: refs/heads/master
Commit: 0f4aac7359dd7010509643d8d7cc2b5bb1b27dc9
Parents: 117870c
Author: Rafael da Fonseca <rsafonseca@gmail.com>
Authored: Sun Jun 14 21:12:35 2015 +0200
Committer: Rohit Yadav <rohit.yadav@shapeblue.com>
Committed: Mon Jun 15 12:17:53 2015 +0300

----------------------------------------------------------------------
 .../orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/0f4aac73/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
----------------------------------------------------------------------
diff --git a/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java b/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
index 918476c..f4952b5 100644
--- a/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
+++ b/engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
@@ -457,7 +457,6 @@ public class AgentManagerImpl extends ManagerBase implements AgentManager,
Handl
     }
 
     protected AgentAttache getAttache(final Long hostId) throws AgentUnavailableException
{
-        assert (hostId != null) : "Who didn't check their id value?";
         if (hostId == null) {
             return null;
         }


Mime
View raw message