cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhais...@apache.org
Subject [3/5] git commit: updated refs/heads/master to 509c83b
Date Mon, 15 Jun 2015 09:04:14 GMT
Fix another findbugs encoding warning in CitrixResourceBase In this case, using default encoding
is desired, since the purpose is to read shell command output, which uses the platform's default
encoding. This gets rid of the findbugs warning.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #396


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/cc6d28fc
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/cc6d28fc
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/cc6d28fc

Branch: refs/heads/master
Commit: cc6d28fc98de31a18e9e9e64e088d7291daaadb9
Parents: faa38ad
Author: Rafael da Fonseca <rsafonseca@gmail.com>
Authored: Fri Jun 12 22:47:17 2015 +0200
Committer: Rohit Yadav <rohit.yadav@shapeblue.com>
Committed: Mon Jun 15 11:59:48 2015 +0300

----------------------------------------------------------------------
 .../cloud/hypervisor/xenserver/resource/CitrixResourceBase.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/cc6d28fc/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
index 87b210b..43cdd88 100644
--- a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
+++ b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
@@ -5048,10 +5048,10 @@ public abstract class CitrixResourceBase implements ServerResource,
HypervisorRe
             Process p = Runtime.getRuntime().exec(cmd);
 
             BufferedReader stdInput = new BufferedReader(new
-                    InputStreamReader(p.getInputStream()));
+                    InputStreamReader(p.getInputStream(),Charset.defaultCharset()));
 
             BufferedReader stdError = new BufferedReader(new
-                    InputStreamReader(p.getErrorStream()));
+                    InputStreamReader(p.getErrorStream(),Charset.defaultCharset()));
 
             // read the output from the command
             while ((s = stdInput.readLine()) != null) {


Mime
View raw message