cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject [1/5] git commit: updated refs/heads/master to b272d77
Date Mon, 08 Jun 2015 08:01:36 GMT
Repository: cloudstack
Updated Branches:
  refs/heads/master 9bac84a3f -> b272d7717


Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE,
Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in
com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO,
String)

Assertion is not used in runtime, correct way is throw and handle exception without killing
app

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #362


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/e8c7069f
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/e8c7069f
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/e8c7069f

Branch: refs/heads/master
Commit: e8c7069f734b7886cbe0e8dfec4452a4fdfe20b3
Parents: 9bac84a
Author: Rafael da Fonseca <rsafonseca@gmail.com>
Authored: Sun Jun 7 11:38:04 2015 +0200
Committer: Daan Hoogland <daan.hoogland@gmail.com>
Committed: Mon Jun 8 09:40:50 2015 +0200

----------------------------------------------------------------------
 .../cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java   | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/e8c7069f/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
index 3aec7a4..34ede03 100644
--- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
+++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
@@ -1019,7 +1019,6 @@ public class VmwareStorageManagerImpl implements VmwareStorageManager
{
 
     private String getVolumePathInDatastore(DatastoreMO dsMo, String volumeFileName) throws
Exception {
         String datastoreVolumePath = dsMo.searchFileInSubFolders(volumeFileName, true);
-        assert (datastoreVolumePath != null) : "Virtual disk file missing from datastore.";
         if (datastoreVolumePath == null) {
             throw new CloudRuntimeException("Unable to find file " + volumeFileName + " in
datastore " + dsMo.getName());
         }


Mime
View raw message