cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject git commit: updated refs/heads/master to 6f2fb92
Date Sun, 12 Apr 2015 18:27:26 GMT
Repository: cloudstack
Updated Branches:
  refs/heads/master 9f8a40acd -> 6f2fb9236


findbugs: .equals() on wrapper class

Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/6f2fb923
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/6f2fb923
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/6f2fb923

Branch: refs/heads/master
Commit: 6f2fb9236490a45c120a0d767eae6833a03cc456
Parents: 9f8a40a
Author: Daan Hoogland <dhoogland@schubergphilis.com>
Authored: Sun Apr 12 20:27:23 2015 +0200
Committer: Daan Hoogland <dhoogland@schubergphilis.com>
Committed: Sun Apr 12 20:27:23 2015 +0200

----------------------------------------------------------------------
 .../src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/6f2fb923/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java
----------------------------------------------------------------------
diff --git a/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java
b/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java
index 455535f..676275a 100644
--- a/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java
+++ b/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java
@@ -380,7 +380,7 @@ public class BigSwitchBcfUtils {
             Integer port = rule.getSourcePortStart();
             fwCidrList = _fwCidrsDao.listByFirewallRuleId(rule.getId());
             if(fwCidrList != null){
-                if(fwCidrList.size()>1 || rule.getSourcePortEnd()!=port){
+                if (fwCidrList.size() > 1 || !rule.getSourcePortEnd().equals(port)) {
                     continue;
                 } else {
                     cidr = fwCidrList.get(0).getCidr();
@@ -414,7 +414,7 @@ public class BigSwitchBcfUtils {
                 Integer port = item.getSourcePortStart(); // currently BCF supports single
port policy
                 aclCidrList = _aclItemCidrsDao.listByNetworkACLItemId(item.getId());
                 if(aclCidrList != null){
-                    if(aclCidrList.size()>1 || item.getSourcePortEnd()!=port){
+                    if (aclCidrList.size() > 1 || !item.getSourcePortEnd().equals(port))
{
                         continue;
                     } else {
                         cidr = aclCidrList.get(0).getCidr();


Mime
View raw message