cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject git commit: updated refs/heads/master to d3a98ab
Date Sun, 12 Apr 2015 19:00:23 GMT
Repository: cloudstack
Updated Branches:
  refs/heads/master 67719b1be -> d3a98ab0d


findbugs: comparison of wrapper classes should use equals

Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/d3a98ab0
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/d3a98ab0
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/d3a98ab0

Branch: refs/heads/master
Commit: d3a98ab0d00c787cb0fe2b53d532de65c873f4fb
Parents: 67719b1
Author: Daan Hoogland <dhoogland@schubergphilis.com>
Authored: Sun Apr 12 21:00:21 2015 +0200
Committer: Daan Hoogland <dhoogland@schubergphilis.com>
Committed: Sun Apr 12 21:00:21 2015 +0200

----------------------------------------------------------------------
 .../src/com/cloud/network/element/BigSwitchBcfElement.java       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/d3a98ab0/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
----------------------------------------------------------------------
diff --git a/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
b/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
index 37391a6..1dbf62d 100644
--- a/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
+++ b/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
@@ -684,7 +684,7 @@ NetworkACLServiceProvider, FirewallServiceProvider, ResourceStateAdapter
{
             }
             cidrList = r.getSourceCidrList();
             if(cidrList != null){
-                if(cidrList.size()>1 || r.getSourcePortEnd()!=r.getSourcePortStart()){
+                if (cidrList.size() > 1 || !r.getSourcePortEnd().equals(r.getSourcePortStart()))
{
                     throw new ResourceUnavailableException("One CIDR and one port only please.",
                             Network.class, network.getId());
                 } else {
@@ -718,7 +718,7 @@ NetworkACLServiceProvider, FirewallServiceProvider, ResourceStateAdapter
{
             }
             cidrList = r.getSourceCidrList();
             if(cidrList != null){
-                if(cidrList.size()>1 || r.getSourcePortEnd()!=r.getSourcePortStart()){
+                if (cidrList.size() > 1 || !r.getSourcePortEnd().equals(r.getSourcePortStart()))
{
                     throw new ResourceUnavailableException("One CIDR and one port only please.",
                             Network.class, network.getId());
                 } else {


Mime
View raw message