cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sate...@apache.org
Subject [1/3] git commit: updated refs/heads/vmware-disk-controllers to 1a8fe82
Date Sat, 10 Jan 2015 11:21:05 GMT
Repository: cloudstack
Updated Branches:
  refs/heads/vmware-disk-controllers 85bd96c6b -> 1a8fe8258


UI validation: Fix asterisk showing up on non-required fields


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/82fa9184
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/82fa9184
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/82fa9184

Branch: refs/heads/vmware-disk-controllers
Commit: 82fa9184bfe5f59443a101e1008d57ce77cce53a
Parents: 85bd96c
Author: Brian Federle <brian.federle@citrix.com>
Authored: Wed Jan 7 08:46:59 2015 -0800
Committer: Brian Federle <brian.federle@citrix.com>
Committed: Wed Jan 7 08:49:27 2015 -0800

----------------------------------------------------------------------
 ui/scripts/ui/dialog.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/82fa9184/ui/scripts/ui/dialog.js
----------------------------------------------------------------------
diff --git a/ui/scripts/ui/dialog.js b/ui/scripts/ui/dialog.js
index e5ac14b..051759f 100644
--- a/ui/scripts/ui/dialog.js
+++ b/ui/scripts/ui/dialog.js
@@ -193,11 +193,12 @@
                         );
 
                 // red asterisk
-                var $astersikSpan = $('<span>').addClass('field-required').html('*');
-                $name.find('label').prepend($astersikSpan);
+                var $asterisk = $('<span>').addClass('field-required').html('*');
 
-                if (field.validation == null || field.validation.required == false) {
-                    $astersikSpan.hide();
+                $name.find('label').prepend($asterisk);
+
+                if (field.validation == null || !field.validation.required) {
+                    $asterisk.hide();
                 }
 
                 // Tooltip description


Mime
View raw message