Return-Path: X-Original-To: apmail-cloudstack-commits-archive@www.apache.org Delivered-To: apmail-cloudstack-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2FDF1724D for ; Sun, 28 Sep 2014 09:40:17 +0000 (UTC) Received: (qmail 84582 invoked by uid 500); 28 Sep 2014 09:40:02 -0000 Delivered-To: apmail-cloudstack-commits-archive@cloudstack.apache.org Received: (qmail 84520 invoked by uid 500); 28 Sep 2014 09:40:02 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 83618 invoked by uid 99); 28 Sep 2014 09:40:02 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Sep 2014 09:40:02 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 984BC9B93AC; Sun, 28 Sep 2014 09:40:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: widodh@apache.org To: commits@cloudstack.apache.org Date: Sun, 28 Sep 2014 09:40:27 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [27/50] [abbrv] git commit: updated refs/heads/statscollector-graphite to 621156c CID-1192822: ids is a List, the cast to List is removed Signed-off-by: Rohit Yadav Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/92858afd Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/92858afd Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/92858afd Branch: refs/heads/statscollector-graphite Commit: 92858afd55a2a19cf698bbbf34c891fbf8087e9d Parents: 2401eb9 Author: Rohit Yadav Authored: Thu Sep 25 16:59:47 2014 +0200 Committer: Rohit Yadav Committed: Thu Sep 25 16:59:47 2014 +0200 ---------------------------------------------------------------------- server/src/com/cloud/api/query/QueryManagerImpl.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/92858afd/server/src/com/cloud/api/query/QueryManagerImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/api/query/QueryManagerImpl.java b/server/src/com/cloud/api/query/QueryManagerImpl.java index 4f775fc..475b42c 100644 --- a/server/src/com/cloud/api/query/QueryManagerImpl.java +++ b/server/src/com/cloud/api/query/QueryManagerImpl.java @@ -912,11 +912,8 @@ public class QueryManagerImpl extends ManagerBase implements QueryService { sc.setParameters("display", display); } - if (ids != null) { - List idList = (ids instanceof List ? (List)ids : null); - if (idList != null && !idList.isEmpty()) { - sc.setParameters("idIN", idList.toArray()); - } + if (ids != null && !ids.isEmpty()) { + sc.setParameters("idIN", ids.toArray()); } if (templateId != null) {