cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ko...@apache.org
Subject [1/2] git commit: updated refs/heads/master to 726d8fc
Date Fri, 02 May 2014 19:20:56 GMT
Repository: cloudstack
Updated Branches:
  refs/heads/master 59d0b75e7 -> 726d8fc3f


log exceptions in ConsoleProxyServlet

- Added exception to the logger method parameters to make stack trace available
- removed checking of debug level, it does not save temporary object creation here

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/78507c07
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/78507c07
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/78507c07

Branch: refs/heads/master
Commit: 78507c07c8189e10762edd129a7385bc4aaa8eef
Parents: 59d0b75
Author: Laszlo Hornyak <laszlo.hornyak@gmail.com>
Authored: Wed Apr 30 21:20:31 2014 +0200
Committer: Laszlo Hornyak <laszlo.hornyak@gmail.com>
Committed: Fri May 2 21:19:48 2014 +0200

----------------------------------------------------------------------
 server/src/com/cloud/servlet/ConsoleProxyServlet.java | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/78507c07/server/src/com/cloud/servlet/ConsoleProxyServlet.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/servlet/ConsoleProxyServlet.java b/server/src/com/cloud/servlet/ConsoleProxyServlet.java
index 16d7a32..ff8453b 100644
--- a/server/src/com/cloud/servlet/ConsoleProxyServlet.java
+++ b/server/src/com/cloud/servlet/ConsoleProxyServlet.java
@@ -237,9 +237,7 @@ public class ConsoleProxyServlet extends HttpServlet {
         try {
             resp.sendRedirect(composeThumbnailUrl(rootUrl, vm, host, w, h));
         } catch (IOException e) {
-            if (s_logger.isInfoEnabled()) {
-                s_logger.info("Client may already close the connection");
-            }
+            s_logger.info("Client may already close the connection", e);
         }
     }
 
@@ -501,9 +499,7 @@ public class ConsoleProxyServlet extends HttpServlet {
             resp.setContentType("text/html");
             resp.getWriter().print(content);
         } catch (IOException e) {
-            if (s_logger.isInfoEnabled()) {
-                s_logger.info("Client may already close the connection");
-            }
+            s_logger.info("Client may already close the connection", e);
         }
     }
 


Mime
View raw message