cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject git commit: updated refs/heads/4.3 to a42a345
Date Sun, 02 Feb 2014 18:51:04 GMT
Updated Branches:
  refs/heads/4.3 438a4b0d5 -> a42a34568


findbugs replaced byte[].toString() with new String(byte[])

Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a42a3456
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a42a3456
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a42a3456

Branch: refs/heads/4.3
Commit: a42a3456841e746bf587aaeff88cd1d473006dd4
Parents: 438a4b0
Author: Daan Hoogland <daan@onecht.net>
Authored: Sun Feb 2 19:50:58 2014 +0100
Committer: Daan Hoogland <daan@onecht.net>
Committed: Sun Feb 2 19:50:58 2014 +0100

----------------------------------------------------------------------
 .../org/apache/cloudstack/api/command/LdapCreateAccountCmd.java    | 2 +-
 .../src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a42a3456/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
----------------------------------------------------------------------
diff --git a/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
b/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
index 981e72e..0878410 100644
--- a/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
+++ b/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
@@ -125,7 +125,7 @@ public class LdapCreateAccountCmd extends BaseCmd {
 			final SecureRandom randomGen = SecureRandom.getInstance("SHA1PRNG");
 			final byte bytes[] = new byte[20];
 			randomGen.nextBytes(bytes);
-			return Base64.encode(bytes).toString();
+			return new String(Base64.encode(bytes));
 		} catch (final NoSuchAlgorithmException e) {
 			throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR,
 					"Failed to generate random password");

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a42a3456/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
----------------------------------------------------------------------
diff --git a/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
b/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
index 1855d5d..5e724e8 100644
--- a/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
+++ b/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
@@ -175,7 +175,7 @@ public class LdapImportUsersCmd extends BaseListCmd {
             final SecureRandom randomGen = SecureRandom.getInstance("SHA1PRNG");
             final byte bytes[] = new byte[20];
             randomGen.nextBytes(bytes);
-            return Base64.encode(bytes).toString();
+            return new String(Base64.encode(bytes));
         } catch (final NoSuchAlgorithmException e) {
             throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to generate
random password");
         }


Mime
View raw message