cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gir...@apache.org
Subject git commit: updated refs/heads/master to 393d437
Date Wed, 08 Jan 2014 06:35:58 GMT
Updated Branches:
  refs/heads/master 54275f4f0 -> 393d437b2


CLOUDSTACK-5627: Removed a validation which expected createVPCOffering to fail if SourceNAT
not provided

createVPCOffering API creates VPC with SourceNat even if not provided as param. So this validation
is not required any more.


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/393d437b
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/393d437b
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/393d437b

Branch: refs/heads/master
Commit: 393d437b2620b6fe49a501db010b87316d689e32
Parents: 54275f4
Author: Girish Shilamkar <girish@clogeny.com>
Authored: Wed Jan 8 12:00:09 2014 +0530
Committer: Girish Shilamkar <girish@clogeny.com>
Committed: Wed Jan 8 12:05:39 2014 +0530

----------------------------------------------------------------------
 test/integration/component/test_vpc_offerings.py | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/393d437b/test/integration/component/test_vpc_offerings.py
----------------------------------------------------------------------
diff --git a/test/integration/component/test_vpc_offerings.py b/test/integration/component/test_vpc_offerings.py
index 4f58022..699cef9 100644
--- a/test/integration/component/test_vpc_offerings.py
+++ b/test/integration/component/test_vpc_offerings.py
@@ -820,19 +820,9 @@ class TestVPCOffering(cloudstackTestCase):
         """Test VPC offering with invalid services"""
 
         # Validate the following
-        # 1. Creating VPC Offering with no SourceNat service should FAIL.
-        # 2. Creating VPC Offering with services NOT supported by VPC
+        # 1. Creating VPC Offering with services NOT supported by VPC
         #    like Firewall should not be allowed
 
-        self.debug("Creating a VPC offering without sourceNAT")
-        self.services["vpc_offering"]["supportedservices"] = 'Dhcp,Dns,PortForwarding,Vpn,Lb,UserData,StaticNat'
-
-        with self.assertRaises(Exception):
-            VpcOffering.create(
-                                self.apiclient,
-                                self.services["vpc_offering"]
-                             )
-
         self.debug("Creating a VPC offering with Firewall")
         self.services["vpc_offering"]["supportedservices"] = 'Dhcp,Dns,PortForwarding,Firewall,Vpn,SourceNat,Lb,UserData,StaticNat'
 


Mime
View raw message