cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From h...@apache.org
Subject [2/2] git commit: updated refs/heads/master to 3bd38eb
Date Tue, 28 Jan 2014 09:00:22 GMT
Findbugs finding : Incorrect use of equality


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/3bd38eb1
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/3bd38eb1
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/3bd38eb1

Branch: refs/heads/master
Commit: 3bd38eb17e4b51bd57e3db2d204105387bfdc7a8
Parents: cc98125
Author: Hugo Trippaers <htrippaers@schubergphilis.com>
Authored: Fri Jan 24 11:58:53 2014 +0000
Committer: Hugo Trippaers <htrippaers@schubergphilis.com>
Committed: Tue Jan 28 08:58:28 2014 +0000

----------------------------------------------------------------------
 .../src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/3bd38eb1/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
index 3cd7a9f..e6ecbc9 100755
--- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
+++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
@@ -166,7 +166,7 @@ public class VmwareServerDiscoverer extends DiscovererBase implements
Discoverer
                 _clusterDetailsDao.persist(clusterId, clusterDetails);
             }
             String updatedInventoryPath = validateCluster(url, vmwareDc);
-            if (url.getPath() != updatedInventoryPath) {
+            if (!url.getPath().equals(updatedInventoryPath)) {
                 // If url from API doesn't specify DC then update url in database with DC
associated with this zone.
                 clusterDetails.put("url", url.getScheme() + "://" + url.getHost() + updatedInventoryPath);
                 _clusterDetailsDao.persist(clusterId, clusterDetails);


Mime
View raw message