Return-Path: 
 <commits-return-34141-apmail-cloudstack-commits-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-commits-archive@www.apache.org
Delivered-To: apmail-cloudstack-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A4A1B1093E
	for <apmail-cloudstack-commits-archive@www.apache.org>;
 Thu,  7 Nov 2013 15:23:31 +0000 (UTC)
Received: (qmail 60681 invoked by uid 500); 7 Nov 2013 15:23:31 -0000
Delivered-To: apmail-cloudstack-commits-archive@cloudstack.apache.org
Received: (qmail 60645 invoked by uid 500); 7 Nov 2013 15:23:31 -0000
Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:commits@cloudstack.apache.org>
List-Id: <commits.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list commits@cloudstack.apache.org
Received: (qmail 60631 invoked by uid 99); 7 Nov 2013 15:23:30 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Nov 2013 15:23:30 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 0728E31D207; Thu,  7 Nov 2013 15:23:30 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: hugo@apache.org
To: commits@cloudstack.apache.org
Date: Thu, 07 Nov 2013 15:23:29 -0000
Message-Id: <49c5ebbe780f4c00b7385785a75aabbf@git.apache.org>
X-Mailer: ASF-Git Admin Mailer
Subject: [1/2] git commit: updated refs/heads/master to f6f4a93

Updated Branches:
  refs/heads/master 3f5b8f706 -> f6f4a9314


Fix CID 1116743 Resource leak


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f6f4a931
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f6f4a931
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f6f4a931

Branch: refs/heads/master
Commit: f6f4a9314517023487409ac7cea96adb7b4c0256
Parents: 5cb3cd6
Author: Hugo Trippaers <htrippaers@schubergphilis.com>
Authored: Thu Nov 7 16:22:53 2013 +0100
Committer: Hugo Trippaers <htrippaers@schubergphilis.com>
Committed: Thu Nov 7 16:23:20 2013 +0100

----------------------------------------------------------------------
 .../cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f6f4a931/engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java
----------------------------------------------------------------------
diff --git a/engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java b/engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java
index ee00dd5..7b9cf95 100644
--- a/engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java
+++ b/engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java
@@ -203,12 +203,17 @@ public class SnapshotDataStoreDaoImpl extends GenericDaoBase<SnapshotDataStoreVO
             rs = pstmt.executeQuery();
             while (rs.next()) {
                 long sid = rs.getLong(1);
-                String rl = rs.getString(2);
                 long snid = rs.getLong(3);
                 return findByStoreSnapshot(role, sid, snid);
             }
         } catch (SQLException e) {
             s_logger.debug("Failed to find parent snapshot: " + e.toString());
+        } finally {
+            try {
+                if (pstmt != null)
+                    pstmt.close();
+            } catch (SQLException e) {
+            }
         }
         return null;
     }