cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bfede...@apache.org
Subject [02/10] git commit: updated refs/heads/ui-restyle to 7289604
Date Sat, 28 Sep 2013 00:05:52 GMT
CLOUDSTACK-4745: Add StaticNatRule through firewall manager

This would fix CreateIpForwardingCmd API on 4.2+.


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/dad47682
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/dad47682
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/dad47682

Branch: refs/heads/ui-restyle
Commit: dad47682cbe0b468d07d0b44486f4a2ec5a71eb2
Parents: 522860c
Author: Sheng Yang <sheng.yang@citrix.com>
Authored: Thu Sep 26 13:59:35 2013 -0700
Committer: Sheng Yang <sheng.yang@citrix.com>
Committed: Thu Sep 26 14:00:32 2013 -0700

----------------------------------------------------------------------
 .../cloud/network/firewall/FirewallManagerImpl.java   | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/dad47682/server/src/com/cloud/network/firewall/FirewallManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/network/firewall/FirewallManagerImpl.java b/server/src/com/cloud/network/firewall/FirewallManagerImpl.java
index 773c2c8..c86476e 100644
--- a/server/src/com/cloud/network/firewall/FirewallManagerImpl.java
+++ b/server/src/com/cloud/network/firewall/FirewallManagerImpl.java
@@ -553,6 +553,8 @@ public class FirewallManagerImpl extends ManagerBase implements FirewallService,
             throws ResourceUnavailableException {
         boolean handled = false;
         switch (purpose){
+        /* StaticNatRule would be applied by Firewall provider, since the incompatible of
two object */
+        case StaticNat:
         case Firewall:
             for (FirewallServiceProvider fwElement: _firewallElements) {
                 Network.Provider provider = fwElement.getProvider();
@@ -577,18 +579,6 @@ public class FirewallManagerImpl extends ManagerBase implements FirewallService,
                     break;
             }
             break;
-        case StaticNat:
-            for (StaticNatServiceProvider element: _staticNatElements) {
-                Network.Provider provider = element.getProvider();
-                boolean  isSnatProvider = _networkModel.isProviderSupportServiceInNetwork(network.getId(),
Service.StaticNat, provider);
-                if (!isSnatProvider) {
-                    continue;
-                }
-                handled = element.applyStaticNats(network, (List<? extends StaticNat>)
rules);
-                if (handled)
-                    break;
-            }
-            break;
 /*        case NetworkACL:
             for (NetworkACLServiceProvider element: _networkAclElements) {
                 Network.Provider provider = element.getProvider();


Mime
View raw message