cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prachida...@apache.org
Subject [3/3] git commit: updated refs/heads/4.2-forward to 8dfd34c
Date Fri, 13 Sep 2013 23:56:14 GMT
CLOUDSTACK-4651: Restarting management server when volume Snapshot is still in progress for
root volume of a VM , then there is no way to restart VM since the startVM job is stuck forever
since the volume is in "Snapshoting" state.

Change:
-If no volume of the VM is usable, VM cannot be deployed or started. Atleast ROOT volume should
always be in usable state to start up the VM


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8dfd34cd
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8dfd34cd
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8dfd34cd

Branch: refs/heads/4.2-forward
Commit: 8dfd34cd7e0b39bb002ba192026a2dfbb231de61
Parents: f3be68a
Author: Prachi Damle <prachi@cloud.com>
Authored: Fri Sep 13 14:56:43 2013 -0700
Committer: Prachi Damle <prachi@cloud.com>
Committed: Fri Sep 13 16:55:44 2013 -0700

----------------------------------------------------------------------
 server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8dfd34cd/server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java b/server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index 2ca58c6..6d36a07 100644
--- a/server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -1054,6 +1054,11 @@ public class DeploymentPlanningManagerImpl extends ManagerBase implements
Deploy
         Map<Volume, List<StoragePool>> suitableVolumeStoragePools = new HashMap<Volume,
List<StoragePool>>();
         List<Volume> readyAndReusedVolumes = new ArrayList<Volume>();
 
+        // There should be atleast the ROOT volume of the VM in usable state
+        if (volumesTobeCreated.isEmpty()) {
+            throw new CloudRuntimeException("Unable to create deployment, no usable volumes
found for the VM");
+        }
+
         // for each volume find list of suitable storage pools by calling the
         // allocators
         for (VolumeVO toBeCreated : volumesTobeCreated) {


Mime
View raw message