cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t..@apache.org
Subject [1/2] git commit: updated refs/heads/4.2 to a82f66e
Date Tue, 20 Aug 2013 11:59:03 GMT
Updated Branches:
  refs/heads/4.2 319a7bf05 -> a82f66e0f


CLOUDSTACK-4257: Additional asserts for storage migration test

Test whether valid storage pools are listed and at least one pool is
available for migration.

Signed-off-by: Prasanna Santhanam <tsp@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a82f66e0
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a82f66e0
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a82f66e0

Branch: refs/heads/4.2
Commit: a82f66e0fa8c9e20b0468aae82871c46a9f8b67e
Parents: a9e45bf
Author: Prasanna Santhanam <tsp@apache.org>
Authored: Tue Aug 20 17:24:05 2013 +0530
Committer: Prasanna Santhanam <tsp@apache.org>
Committed: Tue Aug 20 17:24:56 2013 +0530

----------------------------------------------------------------------
 test/integration/component/test_storage_motion.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a82f66e0/test/integration/component/test_storage_motion.py
----------------------------------------------------------------------
diff --git a/test/integration/component/test_storage_motion.py b/test/integration/component/test_storage_motion.py
index 8ddbebe..36376f3 100644
--- a/test/integration/component/test_storage_motion.py
+++ b/test/integration/component/test_storage_motion.py
@@ -259,8 +259,11 @@ class TestStorageMotion(cloudstackTestCase):
                               self.apiclient,
                               id=volume.id
                               )
-            if not pools or pools is None:
-                self.skipTest("No suitable storage pools found for volume migration.Skipping")
+            if not pools:
+                self.skipTest("No suitable storage pools found for volume migration. Skipping")
+
+            self.assert_(isinstance(pools, list), "invalid pool response from listStoragePoolsForMigration:
%s" %pools)
+            self.assert_(len(pools) > 0, "no valid storage pools found for migration")
 
             pool = pools[0]
             self.debug("Migrating Volume-ID: %s to Pool: %s" % (


Mime
View raw message