cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t..@apache.org
Subject git commit: updated refs/heads/4.2 to c93c321
Date Tue, 30 Jul 2013 09:33:48 GMT
Updated Branches:
  refs/heads/4.2 90c6fcf2a -> c93c321b3


CLOUDSTACK-3921: AssociateIpAddress fails

When you have a method with named parameters, all calls to it should
explicitly pass name=value pairs. Not doing so can result in the wrong
params being passed in the method call. This is a result of the
"services" dictionary being passed into the isportable flag failing the
API signature generation and hence the API call.

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 28835054e63432f170c8723a4967d1f480a3c4da)


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/c93c321b
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/c93c321b
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/c93c321b

Branch: refs/heads/4.2
Commit: c93c321b3b64c2d7ad9760d14a2a4520abf3f92a
Parents: 90c6fcf
Author: Prasanna Santhanam <tsp@apache.org>
Authored: Tue Jul 30 15:01:34 2013 +0530
Committer: Prasanna Santhanam <tsp@apache.org>
Committed: Tue Jul 30 15:03:25 2013 +0530

----------------------------------------------------------------------
 tools/marvin/marvin/integration/lib/base.py | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/c93c321b/tools/marvin/marvin/integration/lib/base.py
----------------------------------------------------------------------
diff --git a/tools/marvin/marvin/integration/lib/base.py b/tools/marvin/marvin/integration/lib/base.py
index b552aba..48c49ab 100755
--- a/tools/marvin/marvin/integration/lib/base.py
+++ b/tools/marvin/marvin/integration/lib/base.py
@@ -275,14 +275,14 @@ class VirtualMachine:
         @return:
         """
         public_ip = PublicIPAddress.create(
-            apiclient,
-            virtual_machine.account,
-            virtual_machine.zoneid,
-            virtual_machine.domainid,
-            services
+            apiclient=apiclient,
+            accountid=virtual_machine.account,
+            zoneid=virtual_machine.zoneid,
+            domainid=virtual_machine.domainid,
+            services=services
         )
         FireWallRule.create(
-            apiclient,
+            apiclient=apiclient,
             ipaddressid=public_ip.ipaddress.id,
             protocol='TCP',
             cidrlist=['0.0.0.0/0'],
@@ -290,9 +290,9 @@ class VirtualMachine:
             endport=22
         )
         nat_rule = NATRule.create(
-            apiclient,
-            virtual_machine,
-            services,
+            apiclient=apiclient,
+            virtual_machine=virtual_machine,
+            services=services,
             ipaddressid=public_ip.ipaddress.id
         )
         virtual_machine.ssh_ip = nat_rule.ipaddress


Mime
View raw message