cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kelv...@apache.org
Subject [1/2] git commit: updated refs/heads/vmsync to 3327371
Date Wed, 05 Jun 2013 00:29:06 GMT
Updated Branches:
  refs/heads/vmsync bd0c239f6 -> 3327371f9


Add some comments to help collabrate with other developer


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/70728a74
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/70728a74
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/70728a74

Branch: refs/heads/vmsync
Commit: 70728a74713ab5fbe375bff83c34cc2eb2159a95
Parents: bd0c239
Author: Kelven Yang <kelveny@gmail.com>
Authored: Tue Jun 4 15:25:15 2013 -0700
Committer: Kelven Yang <kelveny@gmail.com>
Committed: Tue Jun 4 15:25:33 2013 -0700

----------------------------------------------------------------------
 .../framework/jobs/AsyncJobDispatcher.java         |    5 ++++
 .../cloudstack/framework/jobs/AsyncJobManager.java |   18 +++++++-------
 2 files changed, 14 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/70728a74/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobDispatcher.java
----------------------------------------------------------------------
diff --git a/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobDispatcher.java
b/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobDispatcher.java
index b46059c..5b0d15d 100644
--- a/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobDispatcher.java
+++ b/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobDispatcher.java
@@ -18,6 +18,11 @@ package org.apache.cloudstack.framework.jobs;
 
 import com.cloud.utils.component.Adapter;
 
+//
+// We extend it from Adapter interface for
+//	1)	getName()/setName()
+//	2)	Confirming to general adapter pattern used across CloudStack
+//
 public interface AsyncJobDispatcher extends Adapter {
 	void runJob(AsyncJob job);
 }

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/70728a74/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobManager.java
----------------------------------------------------------------------
diff --git a/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobManager.java
b/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobManager.java
index 66c56e2..e577fb0 100644
--- a/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobManager.java
+++ b/framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobManager.java
@@ -1,4 +1,4 @@
-// Licensed to the Apache Software Foundation (ASF) under one
+// Licensed to the Apache Software Foundation (ASF) under ones
 // or more contributor license agreements.  See the NOTICE file
 // distributed with this work for additional information
 // regarding copyright ownership.  The ASF licenses this file
@@ -54,10 +54,10 @@ public interface AsyncJobManager extends Manager {
 
     /**
      * Used by upper level job to wait for completion of a down-level job (usually VmWork
jobs)
-     * in synchronized way. Caller needs to use waitAndCheck() to check the completion status
+     * in synchronous way. Caller needs to use waitAndCheck() to check the completion status
      * of the down-level job
      * 
-     * Due to the amount of legacy code that relies on synchronized-call semantics, this
form of joinJob
+     * Due to the amount of legacy code that relies on synchronous-call semantics, this form
of joinJob
      * is used mostly
      * 
      * 
@@ -68,19 +68,19 @@ public interface AsyncJobManager extends Manager {
 	
     /**
      * Used by upper level job to wait for completion of a down-level job (usually VmWork
jobs)
-     * in asynchronized way, it will cause upper job to cease current execution, upper job
will be
+     * in asynchronous way, it will cause upper job to cease current execution, upper job
will be
      * rescheduled to execute periodically or on wakeup events detected from message bus
      * 
      * @param jobId upper job that is going to wait the completion of a down-level job
      * @param joinJobId down-level job
-     * @Param wakeupHandler	wakeup handler
-     * @Param wakeupDispatcher wakeup dispatcher
-     * @param wakeupTopcisOnMessageBus
+     * @Param wakeupHandler	wake-up handler
+     * @Param wakeupDispatcher wake-up dispatcher
+     * @param wakeupTopicsOnMessageBus
      * @param wakeupIntervalInMilliSeconds
      * @param timeoutInMilliSeconds
      */
     void joinJob(long jobId, long joinJobId, String wakeupHandler, String wakupDispatcher,
-    		String[] wakeupTopcisOnMessageBus, long wakeupIntervalInMilliSeconds, long timeoutInMilliSeconds);
+    		String[] wakeupTopicsOnMessageBus, long wakeupIntervalInMilliSeconds, long timeoutInMilliSeconds);
     
     /**
      * Dis-join two related jobs
@@ -107,7 +107,7 @@ public interface AsyncJobManager extends Manager {
     void syncAsyncJobExecution(AsyncJob job, String syncObjType, long syncObjId, long queueSizeLimit);
     
     /**
-     * This method will be deprecated after all code has been migrated to fully-asynchronized
mode
+     * This method will be deprecated after all code has been migrated to fully-asynchronous
mode
      * that uses async-feature of joinJob/disjoinJob
      * 
      * @param wakupTopicsOnMessageBus topic on message bus to wakeup the wait


Mime
View raw message