cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t..@apache.org
Subject [1/3] git commit: updated refs/heads/2554 to eb65cf0
Date Sun, 19 May 2013 10:55:46 GMT
Updated Branches:
  refs/heads/2554 2afb1ad9e -> eb65cf086


Fixing multiple minor annoyances:

1. Keeping the description consistent - Memory not RAM when referring to
overcommit
2. getters And setters grouped, provided right casing.
3. Removed wildcard imports

Signed-off-by: Prasanna Santhanam <tsp@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/296c6d6c
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/296c6d6c
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/296c6d6c

Branch: refs/heads/2554
Commit: 296c6d6cf5443b49f4f5ded76ef47d0f9df288d2
Parents: 2afb1ad
Author: Prasanna Santhanam <tsp@apache.org>
Authored: Sun May 19 15:56:30 2013 +0530
Committer: Prasanna Santhanam <tsp@apache.org>
Committed: Sun May 19 16:25:15 2013 +0530

----------------------------------------------------------------------
 .../api/command/admin/cluster/AddClusterCmd.java   |   36 +++++++--------
 .../command/admin/cluster/UpdateClusterCmd.java    |    6 +-
 .../cloudstack/api/response/ClusterResponse.java   |   27 ++++++-----
 server/src/com/cloud/api/ApiResponseHelper.java    |   10 +---
 .../com/cloud/capacity/CapacityManagerImpl.java    |   20 ++++----
 .../com/cloud/resource/ResourceManagerImpl.java    |   12 +++---
 .../com/cloud/vm/VirtualMachineManagerImpl.java    |    4 +-
 .../com/cloud/vm/VirtualMachineProfileImpl.java    |   34 +++++++-------
 8 files changed, 69 insertions(+), 80 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/296c6d6c/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java
----------------------------------------------------------------------
diff --git a/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java b/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java
index d55ccd7..c6ca9bc6 100644
--- a/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java
@@ -17,13 +17,11 @@
 
 package org.apache.cloudstack.api.command.admin.cluster;
 
-import java.util.ArrayList;
-import java.util.List;
-
+import com.cloud.exception.DiscoveryException;
 import com.cloud.exception.InvalidParameterValueException;
-import org.apache.cloudstack.api.*;
-import org.apache.log4j.Logger;
-
+import com.cloud.exception.ResourceInUseException;
+import com.cloud.org.Cluster;
+import com.cloud.user.Account;
 import org.apache.cloudstack.api.APICommand;
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.ApiErrorCode;
@@ -36,10 +34,8 @@ import org.apache.cloudstack.api.response.PodResponse;
 import org.apache.cloudstack.api.response.ZoneResponse;
 import org.apache.log4j.Logger;
 
-import com.cloud.exception.DiscoveryException;
-import com.cloud.exception.ResourceInUseException;
-import com.cloud.org.Cluster;
-import com.cloud.user.Account;
+import java.util.ArrayList;
+import java.util.List;
 
 @APICommand(name = "addCluster", description="Adds a new cluster", responseObject=ClusterResponse.class)
 public class AddClusterCmd extends BaseCmd {
@@ -86,10 +82,10 @@ public class AddClusterCmd extends BaseCmd {
     private String vsmipaddress;
 
     @Parameter (name=ApiConstants.CPU_OVERCOMMIT_RATIO, type = CommandType.STRING, required
= false , description = "value of the cpu overcommit ratio, defaults to 1")
-    private String  cpuovercommitRatio;
+    private String cpuOvercommitRatio;
 
-    @Parameter(name = ApiConstants.MEMORY_OVERCOMMIT_RATIO, type = CommandType.STRING, required
= false ,description = "value of the default ram overcommit ratio, defaults to 1")
-    private String  memoryovercommitratio;
+    @Parameter(name = ApiConstants.MEMORY_OVERCOMMIT_RATIO, type = CommandType.STRING, required
= false, description = "value of the default memory overcommit ratio, defaults to 1")
+    private String memoryOvercommitRatio;
 
     @Parameter(name = ApiConstants.VSWITCH_TYPE_GUEST_TRAFFIC, type = CommandType.STRING,
required = false, description = "Type of virtual switch used for guest traffic in the cluster.
Allowed values are, vmwaresvs (for VMware standard vSwitch) and vmwaredvs (for VMware distributed
vSwitch)")
     private String vSwitchTypeGuestTraffic;
@@ -186,15 +182,15 @@ public class AddClusterCmd extends BaseCmd {
     }
 
     public Float getCpuOvercommitRatio (){
-        if(cpuovercommitRatio != null){
-           return Float.parseFloat(cpuovercommitRatio);
+        if(cpuOvercommitRatio != null){
+           return Float.parseFloat(cpuOvercommitRatio);
         }
         return 1.0f;
     }
 
-    public Float getMemoryOvercommitRaito (){
-        if (memoryovercommitratio != null){
-            return Float.parseFloat(memoryovercommitratio);
+    public Float getMemoryOvercommitRatio(){
+        if (memoryOvercommitRatio != null){
+            return Float.parseFloat(memoryOvercommitRatio);
         }
         return 1.0f;
     }
@@ -202,8 +198,8 @@ public class AddClusterCmd extends BaseCmd {
     @Override
     public void execute(){
         try {
-            if ((getMemoryOvercommitRaito().compareTo(1f) < 0) | (getCpuOvercommitRatio().compareTo(1f)
< 0)) {
-                throw new InvalidParameterValueException("Cpu and ram overcommit ratios 
should not be less than 1");
+            if (getMemoryOvercommitRatio().compareTo(1f) < 0 || getCpuOvercommitRatio().compareTo(1f)
< 0) {
+                throw new InvalidParameterValueException("cpu and memory overcommit ratios
should be greater than or equal to one");
             }
             List<? extends Cluster> result = _resourceService.discoverCluster(this);
             ListResponse<ClusterResponse> response = new ListResponse<ClusterResponse>();

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/296c6d6c/api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java
----------------------------------------------------------------------
diff --git a/api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java
b/api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java
index c513058..a14f905 100644
--- a/api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java
@@ -57,7 +57,7 @@ public class UpdateClusterCmd extends BaseCmd {
     @Parameter(name=ApiConstants.CPU_OVERCOMMIT_RATIO, type = CommandType.STRING, description
= "Value of cpu overcommit ratio")
     private String cpuovercommitratio;
 
-    @Parameter(name=ApiConstants.MEMORY_OVERCOMMIT_RATIO, type = CommandType.STRING, description
= "Value of ram overcommit ratio")
+    @Parameter(name=ApiConstants.MEMORY_OVERCOMMIT_RATIO, type = CommandType.STRING, description
= "Value of memory overcommit ratio")
     private String memoryovercommitratio;
 
 
@@ -129,13 +129,13 @@ public class UpdateClusterCmd extends BaseCmd {
         }
         if (getMemoryOvercommitRaito() !=null){
             if ((getMemoryOvercommitRaito().compareTo(1f) < 0)) {
-                throw new InvalidParameterValueException("Memory overcommit ratio  should
be greater than or equal to one");
+                throw new InvalidParameterValueException("Memory overcommit ratio should
be greater than or equal to one");
             }
         }
 
         if (getCpuOvercommitRatio() !=null){
             if (getCpuOvercommitRatio().compareTo(1f) < 0) {
-                throw new InvalidParameterValueException("Cpu overcommit ratio  should be
greater than or equal to one");
+                throw new InvalidParameterValueException("Cpu overcommit ratio should be
greater than or equal to one");
             }
         }
 

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/296c6d6c/api/src/org/apache/cloudstack/api/response/ClusterResponse.java
----------------------------------------------------------------------
diff --git a/api/src/org/apache/cloudstack/api/response/ClusterResponse.java b/api/src/org/apache/cloudstack/api/response/ClusterResponse.java
index cfd772d..ef8cca6 100644
--- a/api/src/org/apache/cloudstack/api/response/ClusterResponse.java
+++ b/api/src/org/apache/cloudstack/api/response/ClusterResponse.java
@@ -16,16 +16,15 @@
 // under the License.
 package org.apache.cloudstack.api.response;
 
-import java.util.ArrayList;
-import java.util.List;
-
+import com.cloud.org.Cluster;
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.BaseResponse;
 import org.apache.cloudstack.api.EntityReference;
 
-import com.cloud.org.Cluster;
-import com.cloud.serializer.Param;
-import com.google.gson.annotations.SerializedName;
+import java.util.ArrayList;
+import java.util.List;
 
 @EntityReference(value = Cluster.class)
 public class ClusterResponse extends BaseResponse {
@@ -68,7 +67,7 @@ public class ClusterResponse extends BaseResponse {
     @SerializedName("cpuovercommitratio") @Param(description = "The cpu overcommit ratio
of the cluster")
     private String cpuovercommitratio;
 
-    @SerializedName("memoryovercommitratio") @Param (description = "The ram overcommit ratio
of the cluster")
+    @SerializedName("memoryovercommitratio") @Param (description = "The memory overcommit
ratio of the cluster")
     private String memoryovercommitratio;
 
     public String getId() {
@@ -162,18 +161,20 @@ public class ClusterResponse extends BaseResponse {
     public void setCapacitites(ArrayList<CapacityResponse> arrayList) {
         this.capacitites = arrayList;
     }
-    public void setCpuovercommitratio(String cpuovercommitratio){
+
+    public void setCpuOvercommitRatio(String cpuovercommitratio){
         this.cpuovercommitratio= cpuovercommitratio;
     }
-    public void setRamovercommitratio (String memoryOvercommitRatio){
-        this.memoryovercommitratio= memoryOvercommitRatio;
-    }
 
-    public String getCpuovercommitratio (){
+    public String getCpuOvercommitRatio(){
         return cpuovercommitratio;
     }
 
-    public String getRamovercommitratio (){
+    public void setMemoryOvercommitRatio(String memoryovercommitratio){
+        this.memoryovercommitratio= memoryovercommitratio;
+    }
+
+    public String getMemoryOvercommitRatio(){
         return memoryovercommitratio;
     }
 }

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/296c6d6c/server/src/com/cloud/api/ApiResponseHelper.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/api/ApiResponseHelper.java b/server/src/com/cloud/api/ApiResponseHelper.java
index 482594d..49e36dc 100755
--- a/server/src/com/cloud/api/ApiResponseHelper.java
+++ b/server/src/com/cloud/api/ApiResponseHelper.java
@@ -40,12 +40,6 @@ import com.cloud.network.vpc.PrivateGateway;
 import com.cloud.network.vpc.StaticRoute;
 import com.cloud.network.vpc.Vpc;
 import com.cloud.network.vpc.VpcOffering;
-import com.cloud.vm.*;
-import com.cloud.network.vpc.NetworkACL;
-import com.cloud.network.vpc.PrivateGateway;
-import com.cloud.network.vpc.StaticRoute;
-import com.cloud.network.vpc.Vpc;
-import com.cloud.network.vpc.VpcOffering;
 import org.apache.cloudstack.acl.ControlledEntity;
 import org.apache.cloudstack.acl.ControlledEntity.ACLType;
 import org.apache.cloudstack.affinity.AffinityGroup;
@@ -975,8 +969,8 @@ public class ApiResponseHelper implements ResponseGenerator {
         clusterResponse.setManagedState(cluster.getManagedState().toString());
         String cpuOvercommitRatio=ApiDBUtils.findClusterDetails(cluster.getId(),"cpuOvercommitRatio").getValue();
         String memoryOvercommitRatio=ApiDBUtils.findClusterDetails(cluster.getId(),"memoryOvercommitRatio").getValue();
-        clusterResponse.setCpuovercommitratio(cpuOvercommitRatio);
-        clusterResponse.setRamovercommitratio(memoryOvercommitRatio);
+        clusterResponse.setCpuOvercommitRatio(cpuOvercommitRatio);
+        clusterResponse.setMemoryOvercommitRatio(memoryOvercommitRatio);
 
 
         if (showCapacities != null && showCapacities) {

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/296c6d6c/server/src/com/cloud/capacity/CapacityManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/capacity/CapacityManagerImpl.java b/server/src/com/cloud/capacity/CapacityManagerImpl.java
index 2f82b68..e58ae40 100755
--- a/server/src/com/cloud/capacity/CapacityManagerImpl.java
+++ b/server/src/com/cloud/capacity/CapacityManagerImpl.java
@@ -177,10 +177,10 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager,
         ServiceOfferingVO svo = _offeringsDao.findById(vm.getServiceOfferingId());
         CapacityVO capacityCpu = _capacityDao.findByHostIdType(hostId, CapacityVO.CAPACITY_TYPE_CPU);
         CapacityVO capacityMemory = _capacityDao.findByHostIdType(hostId, CapacityVO.CAPACITY_TYPE_MEMORY);
-        Long clusterId=null;
+        Long clusterId = null;
         if (hostId != null) {
-        HostVO host = _hostDao.findById(hostId);
-        clusterId= host.getClusterId();
+            HostVO host = _hostDao.findById(hostId);
+            clusterId = host.getClusterId();
         }
         if (capacityCpu == null || capacityMemory == null || svo == null) {
             return false;
@@ -263,8 +263,8 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager,
         long hostId = vm.getHostId();
         HostVO host = _hostDao.findById(hostId);
         long clusterId = host.getClusterId();
-        float cpuOvercommitRatio =Float.parseFloat(_clusterDetailsDao.findDetail(clusterId,"cpuOvercommitRatio").getValue());
-        float memoryOvercommitRatio = Float.parseFloat(_clusterDetailsDao.findDetail(clusterId,"memoryOvercommitRatio").getValue());
+        float cpuOvercommitRatio = Float.parseFloat(_clusterDetailsDao.findDetail(clusterId,
"cpuOvercommitRatio").getValue());
+        float memoryOvercommitRatio = Float.parseFloat(_clusterDetailsDao.findDetail(clusterId,
"memoryOvercommitRatio").getValue());
 
         ServiceOfferingVO svo = _offeringsDao.findById(vm.getServiceOfferingId());
 
@@ -348,7 +348,7 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager,
     }
 
     @Override
-    public boolean checkIfHostHasCapacity(long hostId, Integer cpu, long ram, boolean checkFromReservedCapacity,
float cpuOvercommitRatio,float memoryOvercommitRatio, boolean considerReservedCapacity) {
+    public boolean checkIfHostHasCapacity(long hostId, Integer cpu, long ram, boolean checkFromReservedCapacity,
float cpuOvercommitRatio, float memoryOvercommitRatio, boolean considerReservedCapacity) {
         boolean hasCapacity = false;
 
         if (s_logger.isDebugEnabled()) {
@@ -381,7 +381,7 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager,
         long actualTotalCpu = capacityCpu.getTotalCapacity();
         long actualTotalMem = capacityMem.getTotalCapacity();
         long totalCpu = (long) (actualTotalCpu * cpuOvercommitRatio );
-        long totalMem = (long) (actualTotalMem *memoryOvercommitRatio );
+        long totalMem = (long) (actualTotalMem * memoryOvercommitRatio);
         if (s_logger.isDebugEnabled()) {
             s_logger.debug("Hosts's actual total CPU: " + actualTotalCpu + " and CPU after
applying overprovisioning: " + totalCpu);
         }
@@ -744,8 +744,8 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager,
             capacityCPU.addAnd("podId", SearchCriteria.Op.EQ, server.getPodId());
             capacityCPU.addAnd("capacityType", SearchCriteria.Op.EQ, CapacityVO.CAPACITY_TYPE_CPU);
             List<CapacityVO> capacityVOCpus = _capacityDao.search(capacitySC, null);
-            Float cpuovercommitratio = Float.parseFloat(_clusterDetailsDao.findDetail(server.getClusterId(),"cpuOvercommitRatio").getValue());
-            Float memoryOvercommitRatio = Float.parseFloat(_clusterDetailsDao.findDetail(server.getClusterId(),"memoryOvercommitRatio").getValue());
+            Float cpuovercommitratio = Float.parseFloat(_clusterDetailsDao.findDetail(server.getClusterId(),
"cpuOvercommitRatio").getValue());
+            Float memoryOvercommitRatio = Float.parseFloat(_clusterDetailsDao.findDetail(server.getClusterId(),
"memoryOvercommitRatio").getValue());
 
             if (capacityVOCpus != null && !capacityVOCpus.isEmpty()) {
                 CapacityVO CapacityVOCpu = capacityVOCpus.get(0);
@@ -778,7 +778,7 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager,
 
             if (capacityVOMems != null && !capacityVOMems.isEmpty()) {
                 CapacityVO CapacityVOMem = capacityVOMems.get(0);
-                long newTotalMem = (long)((server.getTotalMemory())* memoryOvercommitRatio);
+                long newTotalMem = (long) ((server.getTotalMemory()) * memoryOvercommitRatio);
                 if (CapacityVOMem.getTotalCapacity() <= newTotalMem
                         || (CapacityVOMem.getUsedCapacity() + CapacityVOMem.getReservedCapacity()
<= newTotalMem)) {
                     CapacityVOMem.setTotalCapacity(newTotalMem);

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/296c6d6c/server/src/com/cloud/resource/ResourceManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/resource/ResourceManagerImpl.java b/server/src/com/cloud/resource/ResourceManagerImpl.java
index c60f095..25f451e 100755
--- a/server/src/com/cloud/resource/ResourceManagerImpl.java
+++ b/server/src/com/cloud/resource/ResourceManagerImpl.java
@@ -505,10 +505,10 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager,
         clusterId = cluster.getId();
         result.add(cluster);
 
-           ClusterDetailsVO cluster_detail_cpu = new ClusterDetailsVO(clusterId, "cpuOvercommitRatio",
Float.toString(cmd.getCpuOvercommitRatio()));
-           ClusterDetailsVO cluster_detail_ram = new ClusterDetailsVO(clusterId, "memoryOvercommitRatio",
Float.toString(cmd.getMemoryOvercommitRaito()));
-           _clusterDetailsDao.persist(cluster_detail_cpu);
-           _clusterDetailsDao.persist(cluster_detail_ram);
+        ClusterDetailsVO cluster_detail_cpu = new ClusterDetailsVO(clusterId, "cpuOvercommitRatio",
Float.toString(cmd.getCpuOvercommitRatio()));
+        ClusterDetailsVO cluster_detail_ram = new ClusterDetailsVO(clusterId, "memoryOvercommitRatio",
Float.toString(cmd.getMemoryOvercommitRatio()));
+        _clusterDetailsDao.persist(cluster_detail_cpu);
+        _clusterDetailsDao.persist(cluster_detail_ram);
 
         if (clusterType == Cluster.ClusterType.CloudManaged) {
             return result;
@@ -530,8 +530,8 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager,
         }
 
 
-        if(cmd.getMemoryOvercommitRaito().compareTo(1f) > 0) {
-             cluster_detail_ram = new ClusterDetailsVO(clusterId, "memoryOvercommitRatio",
Float.toString(cmd.getMemoryOvercommitRaito()));
+        if(cmd.getMemoryOvercommitRatio().compareTo(1f) > 0) {
+             cluster_detail_ram = new ClusterDetailsVO(clusterId, "memoryOvercommitRatio",
Float.toString(cmd.getMemoryOvercommitRatio()));
             _clusterDetailsDao.persist(cluster_detail_ram);
         }
 

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/296c6d6c/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
index cea0567..58d95ab 100755
--- a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -824,8 +824,8 @@ public class VirtualMachineManagerImpl extends ManagerBase implements
VirtualMac
                 Long cluster_id = dest.getCluster().getId();
                 ClusterDetailsVO cluster_detail_cpu =  _clusterDetailsDao.findDetail(cluster_id,"cpuOvercommitRatio");
                 ClusterDetailsVO cluster_detail_ram =  _clusterDetailsDao.findDetail(cluster_id,"memoryOvercommitRatio");
-                vmProfile.setcpuOvercommitRatio(Float.parseFloat(cluster_detail_cpu.getValue()));
-                vmProfile.setramOvercommitRatio(Float.parseFloat(cluster_detail_ram.getValue()));
+                vmProfile.setCpuOvercommitRatio(Float.parseFloat(cluster_detail_cpu.getValue()));
+                vmProfile.setMemoryOvercommitRatio(Float.parseFloat(cluster_detail_ram.getValue()));
 
                 try {
                     if (!changeState(vm, Event.OperationRetry, destHostId, work, Step.Prepare))
{

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/296c6d6c/server/src/com/cloud/vm/VirtualMachineProfileImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/vm/VirtualMachineProfileImpl.java b/server/src/com/cloud/vm/VirtualMachineProfileImpl.java
index 24f44cb..e777d5e 100644
--- a/server/src/com/cloud/vm/VirtualMachineProfileImpl.java
+++ b/server/src/com/cloud/vm/VirtualMachineProfileImpl.java
@@ -16,12 +16,6 @@
 // under the License.
 package com.cloud.vm;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
-
 import com.cloud.agent.api.to.VolumeTO;
 import com.cloud.hypervisor.Hypervisor.HypervisorType;
 import com.cloud.offering.ServiceOffering;
@@ -34,6 +28,11 @@ import com.cloud.template.VirtualMachineTemplate.BootloaderType;
 import com.cloud.user.Account;
 import com.cloud.user.dao.AccountDao;
 
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
 /**
  * Implementation of VirtualMachineProfile.
  *
@@ -239,28 +238,27 @@ public class VirtualMachineProfileImpl<T extends VMInstanceVO>
implements Virtua
 	    return _params;
 	}
 
-	public void setServiceOffering(ServiceOfferingVO offering) {
-		_offering = offering;
-	}
+    public void setServiceOffering(ServiceOfferingVO offering) {
+        _offering = offering;
+    }
 
-    public void setcpuOvercommitRatio(Float cpuOvercommitRatio){
-        this.cpuOvercommitRatio= cpuOvercommitRatio;
+    public void setCpuOvercommitRatio(Float cpuOvercommitRatio) {
+        this.cpuOvercommitRatio = cpuOvercommitRatio;
 
     }
 
-    public void setramOvercommitRatio(Float memoryOvercommitRatio){
-        this.memoryOvercommitRatio= memoryOvercommitRatio;
+    public void setMemoryOvercommitRatio(Float memoryOvercommitRatio) {
+        this.memoryOvercommitRatio = memoryOvercommitRatio;
 
     }
+
     @Override
-   public Float getCpuOvercommitRatio(){
-        return  this.cpuOvercommitRatio;
+    public Float getCpuOvercommitRatio() {
+        return this.cpuOvercommitRatio;
     }
 
     @Override
-    public Float getMemoryOvercommitRatio(){
+    public Float getMemoryOvercommitRatio() {
         return this.memoryOvercommitRatio;
     }
-
-
 }


Mime
View raw message