cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chipchild...@apache.org
Subject [2/2] git commit: updated refs/heads/4.1 to f0f7b25
Date Wed, 17 Apr 2013 19:19:49 GMT
CLOUDSTACK-2071 - VirtualMachineManagerImpl.java start() method for instance
can fail to start a VM without notifying caller, if no exception is triggered.
The result is that VM start looks successful but was not. This fixes it by
throwing an exception at the very end if the object to be passed back is still
null.

Signed-off-by: Marcus Sorensen <marcus@betterservers.com> 1366225829 -0600


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f0f7b252
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f0f7b252
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f0f7b252

Branch: refs/heads/4.1
Commit: f0f7b252ea1c2a29db726c36add0af885d615681
Parents: 0c4048c
Author: Marcus Sorensen <marcus@betterservers.com>
Authored: Wed Apr 17 13:10:29 2013 -0600
Committer: Chip Childers <chip.childers@gmail.com>
Committed: Wed Apr 17 20:16:08 2013 +0100

----------------------------------------------------------------------
 .../com/cloud/vm/VirtualMachineManagerImpl.java    |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f0f7b252/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
index 47ed622..2c2986f 100755
--- a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -864,6 +864,11 @@ public class VirtualMachineManagerImpl extends ManagerBase implements
VirtualMac
             }
         }
 
+        if (startedVm == null) {
+            throw new CloudRuntimeException("Unable to start instance '" + vm.getHostName()
+                            + "' (" + vm.getUuid() + "), see management server log for details");
+        }
+
         return startedVm;
     }
 


Mime
View raw message