cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chipchild...@apache.org
Subject git commit: CLOUDSTACK-505: Do not log the command response object for the createSSHKeyPair command. Signed-off-by: Chip Childers <chip.childers@gmail.com>
Date Thu, 29 Nov 2012 17:32:41 GMT
Updated Branches:
  refs/heads/4.0 cf8bc4ba8 -> 8de21b2b7


CLOUDSTACK-505: Do not log the command response object for the createSSHKeyPair command.
Signed-off-by: Chip Childers <chip.childers@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/8de21b2b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/8de21b2b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/8de21b2b

Branch: refs/heads/4.0
Commit: 8de21b2b745ac6eacd209fc801285fe6b82aad28
Parents: cf8bc4b
Author: Chip Childers <chip.childers@gmail.com>
Authored: Thu Nov 29 12:24:42 2012 -0500
Committer: Chip Childers <chip.childers@gmail.com>
Committed: Thu Nov 29 12:31:36 2012 -0500

----------------------------------------------------------------------
 server/src/com/cloud/api/ApiServer.java |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/8de21b2b/server/src/com/cloud/api/ApiServer.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/api/ApiServer.java b/server/src/com/cloud/api/ApiServer.java
index eb5e770..a448663 100755
--- a/server/src/com/cloud/api/ApiServer.java
+++ b/server/src/com/cloud/api/ApiServer.java
@@ -590,7 +590,11 @@ public class ApiServer implements HttpRequestHandler {
             return;
         }
         auditTrailSb.append(" " + HttpServletResponse.SC_OK + " ");
-        auditTrailSb.append(result);
+        if (command.equals("createSSHKeyPair")){
+            auditTrailSb.append("This result was not logged because it contains sensitive
data.");
+        } else {
+            auditTrailSb.append(result);
+        }
         /*
          * if (command.equals("queryAsyncJobResult")){ //For this command we need to also
log job status and job
          * resultcode for


Mime
View raw message