climate-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryer Jeannotte (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CLIMATE-969) Print statements are used instead of functions throughout the project
Date Sun, 29 Sep 2019 19:46:00 GMT

    [ https://issues.apache.org/jira/browse/CLIMATE-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940519#comment-16940519
] 

Bryer Jeannotte commented on CLIMATE-969:
-----------------------------------------

[~agoodman] The explanation about the subfolders and old code makes a lot of sense to me;
I was just looking at the project for the first time, trying stuff out and nosing my way around
when I encountered all the non-py3-compatible code.

 

I have a PR up here: ( [https://github.com/apache/climate/pull/527] ) that was made with
some sed, some manual commands; using 2to3 resulted in much more suggestions across more of
the project, some which could _possibly_ change data types used, so I avoided implementing
those suggestions unless I was able to go through and verify each and every change didn't
break something, which being new to the code I can't attest to yet.

 

I understand and can decline the PR if the consensus is that the affected code is outdated
and not relevant to the project/library.

> Print statements are used instead of functions throughout the project
> ---------------------------------------------------------------------
>
>                 Key: CLIMATE-969
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-969
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: general
>            Reporter: Bryer Jeannotte
>            Priority: Minor
>
> There still exists, throughout the project, the use of print statements instead of print
functions which make using python3 impossible, since that is considered a syntax error.
>  
> Adding the import
> {code:java}
> from __future__ import print_statement{code}
> at the top of the file, and switching statements to functions, will allow the use of
python 2 and 3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message