climate-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Goodman (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CLIMATE-969) Print statements are used instead of functions throughout the project
Date Sat, 28 Sep 2019 23:47:00 GMT

    [ https://issues.apache.org/jira/browse/CLIMATE-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940172#comment-16940172
] 

Alex Goodman commented on CLIMATE-969:
--------------------------------------

[~lewismc] This issue is referring to cases for the subfolders under climate rather than
the OCW library itself. When we worked to make ocw python3 compatible, we didn't really prioritize
the other subfolders so I am not surprised that this is coming up now. I think this speaks
to a larger issue we currently have which is the sheer number of subfolders we have under
the apache/climate repo which are not directly part of OCW. Other than the RCMES subfolder,
none of them have been maintained at all, and some of them do not even call any code from
the OCW library at all. Rather, the climate repo has sort of been used as a dumping ground
for anything related to RCMES including these very old examples. 

Personally, I think the apache/climate repository should only contain the ocw library, tests,
API documentation, and API examples. Everything else is either longtime deprecated code or
old related projects with the exception of the RCMES folder. I am thinking even that should
be maintained separately from ocw/climate, though doing so might break a lot of existing examples
so we could hold off on that. If we don't get rid of them, I think we should at least keep
them inside a separate branch from master. This is not just about keeping things tidy, as
I also think having all of this outdated stuff everywhere can confuse new users and contributors
when they find stuff that doesn't work or are trying to figure out where to contribute. Perhaps
you, me, and Kyo should have a meeting between the three of us after we get back from our
upcoming trip so we can discuss the specifics. We also need to talk about releasing the ocw
replacement I have developed for the past two years to open source, as that is now on the
horizon too.

> Print statements are used instead of functions throughout the project
> ---------------------------------------------------------------------
>
>                 Key: CLIMATE-969
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-969
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: general
>            Reporter: Bryer Jeannotte
>            Priority: Minor
>
> There still exists, throughout the project, the use of print statements instead of print
functions which make using python3 impossible, since that is considered a syntax error.
>  
> Adding the import
> {code:java}
> from __future__ import print_statement{code}
> at the top of the file, and switching statements to functions, will allow the use of
python 2 and 3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message