From dev-return-10626-archive-asf-public=cust-asf.ponee.io@climate.apache.org Tue Jan 22 11:16:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DA683180771 for ; Tue, 22 Jan 2019 11:16:11 +0100 (CET) Received: (qmail 34165 invoked by uid 500); 22 Jan 2019 10:16:11 -0000 Mailing-List: contact dev-help@climate.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@climate.apache.org Delivered-To: mailing list dev@climate.apache.org Received: (qmail 34123 invoked by uid 99); 22 Jan 2019 10:16:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jan 2019 10:16:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 161FEE1348; Tue, 22 Jan 2019 10:16:10 +0000 (UTC) From: markschn To: dev@climate.apache.org Reply-To: dev@climate.apache.org Message-ID: Subject: [GitHub] climate pull request #522: Climate 964 Content-Type: text/plain Date: Tue, 22 Jan 2019 10:16:10 +0000 (UTC) GitHub user markschn opened a pull request: https://github.com/apache/climate/pull/522 Climate 964 The local model files are not downloaded to the temp directory in Windows since the "tmp" directory was introduced in CLIMATE 603. In order to make the downloads work on Windows as well as Linux (and Mac), this pull request uses tempfile.gettempdir() identify the optimal temp file location for that operating system. I am new to this project so I have not yet run the test suite, though I have tested locally. You can merge this pull request into a Git repository by running: $ git pull https://github.com/markschn/climate CLIMATE-964 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/522.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #522 ---- commit 28a4593c634af40bf0385a8ae209ac0afa609d69 Author: Mark Schnitzer Date: 2019-01-22T01:36:17Z added tempfile to get temp directory in example commit 8d9ef6534bbce700585ca95b247b4fb73debf0d6 Author: Mark Schnitzer Date: 2019-01-22T01:49:18Z added comment ---- ---