From dev-return-10324-archive-asf-public=cust-asf.ponee.io@climate.apache.org Mon Feb 19 03:09:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A8FFF18064D for ; Mon, 19 Feb 2018 03:09:06 +0100 (CET) Received: (qmail 65019 invoked by uid 500); 19 Feb 2018 02:09:05 -0000 Mailing-List: contact dev-help@climate.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@climate.apache.org Delivered-To: mailing list dev@climate.apache.org Received: (qmail 65008 invoked by uid 99); 19 Feb 2018 02:09:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Feb 2018 02:09:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 20E8F1A070F for ; Mon, 19 Feb 2018 02:09:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id bakYQDq6K4iZ for ; Mon, 19 Feb 2018 02:09:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 885145F18B for ; Mon, 19 Feb 2018 02:09:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4204FE00E1 for ; Mon, 19 Feb 2018 02:09:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0DEEC21E59 for ; Mon, 19 Feb 2018 02:09:00 +0000 (UTC) Date: Mon, 19 Feb 2018 02:09:00 +0000 (UTC) From: "Michael Anderson (JIRA)" To: dev@climate.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLIMATE-338) RCMED data source loads datasets improperly based on day attribute of time values MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLIMATE-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368746#comment-16368746 ] Michael Anderson commented on CLIMATE-338: ------------------------------------------ The URL used by rcmed.py is as follows: [http://rcmes.jpl.nasa.gov/query-api/query.php?datasetId=10¶meterId=39&latMin=-10&latMax=10&lonMin=-15&lonMax=15&timeStart=19010201T0000Z&timeEnd=19010430T0000Z] The end date has been pushed to the end of the month. > RCMED data source loads datasets improperly based on day attribute of time values > --------------------------------------------------------------------------------- > > Key: CLIMATE-338 > URL: https://issues.apache.org/jira/browse/CLIMATE-338 > Project: Apache Open Climate Workbench > Issue Type: Bug > Components: data sources > Affects Versions: 0.3-incubating > Reporter: Michael Joyce > Assignee: Michael Anderson > Priority: Major > Fix For: 1.3.0 > > Attachments: test.py > > > When trying to load a dataset with `data_source.rcmed` where the time values don't fall on the first of the month the end time is not properly bounded. > Consider CRU31, where the day values fall on the 15th of the month. Notice that the returned end time is not properly bounded by the passed end time. > CRU31 > Passed start time: 1901-02-01 00:00:00 > Returned start time: 1901-02-15 00:00:00 > Passed end time: 1901-04-01 00:00:00 > Returned end time: 1901-04-15 00:00:00 > However, on TRMM, where the time values fall on the first, the values are properly bounded. > TRMM > Passed start time: 1998-02-01 00:00:00 > Returned start time: 1998-02-01 00:00:00 > Passed end time: 1998-03-01 00:00:00 > Returned end time: 1998-03-01 00:00:00 -- This message was sent by Atlassian JIRA (v7.6.3#76005)