climate-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Anderson (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CLIMATE-338) RCMED data source loads datasets improperly based on day attribute of time values
Date Mon, 19 Feb 2018 02:34:00 GMT

    [ https://issues.apache.org/jira/browse/CLIMATE-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368750#comment-16368750
] 

Michael Anderson edited comment on CLIMATE-338 at 2/19/18 2:33 AM:
-------------------------------------------------------------------

[~mjoyce] please see my last comment.  I could do a end_date = min(input end date, calculated
end date), but it seems this logic was by design on the part of the original author.  Proceed
with making the change?  The original comment stated that data which falls on the first of
the month was being bound correctly, but that was really just luck as the actual end date
being sent to RCMED is the end of the month too.


was (Author: michael.arthur.anderson@gmail.com):
[~mjoyce] please see my last comment.  I could do a end_date = min(input end date, calculated
end date), but it seems this logic was by design on the part of the original author.  Proceed
with making the change?

> RCMED data source loads datasets improperly based on day attribute of time values
> ---------------------------------------------------------------------------------
>
>                 Key: CLIMATE-338
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-338
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: data sources
>    Affects Versions: 0.3-incubating
>            Reporter: Michael Joyce
>            Assignee: Michael Anderson
>            Priority: Major
>             Fix For: 1.3.0
>
>         Attachments: test.py
>
>
> When trying to load a dataset with `data_source.rcmed` where the time values don't fall
on the first of the month the end time is not properly bounded. 
> Consider CRU31, where the day values fall on the 15th of the month. Notice that the returned
end time is not properly bounded by the passed end time.
> CRU31
> Passed start time: 1901-02-01 00:00:00
> Returned start time: 1901-02-15 00:00:00
> Passed end time: 1901-04-01 00:00:00
> Returned end time: 1901-04-15 00:00:00
> However, on TRMM, where the time values fall on the first, the values are properly bounded.
> TRMM
> Passed start time: 1998-02-01 00:00:00
> Returned start time: 1998-02-01 00:00:00
> Passed end time: 1998-03-01 00:00:00
> Returned end time: 1998-03-01 00:00:00



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message