climate-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLIMATE-930) multiple file loader forces 2D lats and lons
Date Fri, 29 Sep 2017 05:00:09 GMT

    [ https://issues.apache.org/jira/browse/CLIMATE-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185363#comment-16185363
] 

ASF GitHub Bot commented on CLIMATE-930:
----------------------------------------

GitHub user agoodm opened a pull request:

    https://github.com/apache/climate/pull/456

    CLIMATE-930 - multiple file loader forces 2D lats and lons

    This is mainly to ensure subsetting works properly with the obs4Mips files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agoodm/climate CLIMATE-930

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #456
    
----
commit 032c317be039565645a5c41e39415166720e1109
Author: Alex <agoodm@users.noreply.github.com>
Date:   2017-09-29T04:59:13Z

    CLIMATE-930 - multiple file loader forces 2D lats and lons

----


> multiple file loader forces 2D lats and lons
> --------------------------------------------
>
>                 Key: CLIMATE-930
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-930
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: data sources
>    Affects Versions: 1.2.0
>            Reporter: Alex Goodman
>            Assignee: Alex Goodman
>             Fix For: 1.3.0
>
>
> The multi-file dataset loader forces all lats and lons arrays to be 2D. This leads to
inconsistencies when subsetting since in this scenario the data is simply masked rather than
fully subsetted. At the very least, the behavior should be consistent with the single file
loader which sets the lats and lons to whatever dimensions they originally had in the netcdf
file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message