Mailing-List: contact dev-help@climate.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@climate.apache.org
From: huikyole <git@git.apache.org>
To: dev@climate.apache.org
Reply-To: dev@climate.apache.org
References: <git-pr-441-climate@git.apache.org>
In-Reply-To: <git-pr-441-climate@git.apache.org>
Subject: [GitHub] climate issue #441: CLIMATE-914 - Update dataset_processor.spatial_regrid mo...
Content-Type: text/plain
Message-Id: <20170511045201.346E9DFC2E@git1-us-west.apache.org>
Date: Thu, 11 May 2017 04:52:01 +0000 (UTC)
archived-at: Thu, 11 May 2017 04:52:04 -0000

Github user huikyole commented on the issue:

    https://github.com/apache/climate/pull/441
  
    Thank you for the quick review, @agoodm. In the previous commit, I forgot the nosetests.
    - test_two_dimensional_lats_lons does not make any sense. If latitudes and longitudes are two-dimensional, their shape must be [nY, nX]. I cannot understand why the module had reshaped one-dimensional latitudes and longitudes.
    - We can never trade off accuracy against efficiency. There is no documentation why map_coordinates outputs -9999 without mask. I do not think addressing this bottleneck is our top priority. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---