climate-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLIMATE-912) Upgrade mccSearch code from Python2 > 3
Date Tue, 30 May 2017 21:26:04 GMT

    [ https://issues.apache.org/jira/browse/CLIMATE-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030163#comment-16030163
] 

ASF GitHub Bot commented on CLIMATE-912:
----------------------------------------

Github user kwhitehall commented on the issue:

    https://github.com/apache/climate/pull/439
  
    Hey @lewismc 
    Tested and found the following:
    
    1. need to convert this spaces to tabs in this folder
    2. updated code to reduce the number of datasets needed to test.
    Code for test can be obtained at the this [Google Drive loc](https://drive.google.com/drive/folders/0B0kFBnuqk_GTczFiU3kwWDBXaFk?usp=sharing)
    
    Note that I did a hacky update cause another error flagged in [dataset_processor.py](https://github.com/apache/climate/blob/master/ocw/dataset_processor.py#L1004-1005)
by changing them to:
        spatial_indices_true = np.where(spatial_values.mask.all)
        spatial_indices_false = np.where(not spatial_values.mask.all)
    I haven't included these as something to include in this PR as more investigation needs
to be done to ensure that this doesn't break the code otherwise. 
    
    The PR has been pushed to my local [here](https://github.com/kwhitehall/climate/pull/7).

    I'll work on pushing it to your PR. Do you have direction on this? 
    



> Upgrade mccSearch code from Python2 > 3
> ---------------------------------------
>
>                 Key: CLIMATE-912
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-912
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: mcc search
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> I recently attempted to run the MCC Search code without any luck. Thsi issue will simply
upgrade the code such that it runs with Python 3.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message