climate-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agoodm <...@git.apache.org>
Subject [GitHub] climate issue #441: CLIMATE-914 - Update dataset_processor.spatial_regrid mo...
Date Wed, 10 May 2017 23:51:05 GMT
Github user agoodm commented on the issue:

    https://github.com/apache/climate/pull/441
  
    @huikyole Looks like your changes don't work for 2D latlon arrays, as per CI build logs:
    
    ```
    ======================================================================
    ERROR: test_two_dimensional_lats_lons (ocw.tests.test_dataset_processor.TestSpatialRegrid)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/travis/build/apache/climate/ocw/tests/test_dataset_processor.py", line 399,
in test_two_dimensional_lats_lons
        self.input_dataset, self.new_lats, self.new_lons)
      File "/home/travis/build/apache/climate/ocw/dataset_processor.py", line 278, in spatial_regrid
        new_values_temp = griddata((lons[mask_index], lats[mask_index]), values_original[mask_index],
    IndexError: index 2 is out of bounds for axis 0 with size 2
    ```
    
    Given that regridding is probably one of the largest bottlenecks in our RCMES workflows,
I think it is also worth profiling both this version (once the above error is fixed) and the
old map_coordinates version to see if there are any performance impacts, since the spatial_regridding
tests seem to be running more slowly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message