Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 294F3200AF7 for ; Tue, 14 Jun 2016 14:35:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 281EC160A47; Tue, 14 Jun 2016 12:35:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 70E9D1602C5 for ; Tue, 14 Jun 2016 14:35:07 +0200 (CEST) Received: (qmail 88585 invoked by uid 500); 14 Jun 2016 12:35:06 -0000 Mailing-List: contact dev-help@climate.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@climate.apache.org Delivered-To: mailing list dev@climate.apache.org Received: (qmail 88574 invoked by uid 99); 14 Jun 2016 12:35:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jun 2016 12:35:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 44B32C1FE4 for ; Tue, 14 Jun 2016 12:35:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id a-0-oeyMQUor for ; Tue, 14 Jun 2016 12:35:02 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 020CB5F296 for ; Tue, 14 Jun 2016 12:35:01 +0000 (UTC) Received: (qmail 88414 invoked by uid 99); 14 Jun 2016 12:35:01 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jun 2016 12:35:01 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 33E992C14F9 for ; Tue, 14 Jun 2016 12:35:01 +0000 (UTC) Date: Tue, 14 Jun 2016 12:35:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@climate.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLIMATE-808) Add tests for plotter module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 14 Jun 2016 12:35:08 -0000 [ https://issues.apache.org/jira/browse/CLIMATE-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329416#comment-15329416 ] ASF GitHub Bot commented on CLIMATE-808: ---------------------------------------- Github user OCWJenkins commented on the issue: https://github.com/apache/climate/pull/355 Can one of the admins verify this patch? > Add tests for plotter module > ---------------------------- > > Key: CLIMATE-808 > URL: https://issues.apache.org/jira/browse/CLIMATE-808 > Project: Apache Open Climate Workbench > Issue Type: Sub-task > Components: build process, tests > Reporter: Ibrahim Jarif > Assignee: Ibrahim Jarif > Fix For: 1.1 > > > Most of the code in plotter module cannot be tested as it generates image files.The only way to tests image files is to compare the new image file with existing file pixel by pixel. This will affect the test execution time and build time significantly. Hence ignore functions that generate image files. > To do - > 1. Test the functions that perform some computations. > 2. Update .coveragerc file to ignore image generation code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)