Mailing-List: contact dev-help@climate.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@climate.apache.org
Date: Mon, 9 May 2016 22:15:13 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@climate.incubator.apache.org
Message-ID: <JIRA.12963761.1461907686000.147355.1462832113238@Atlassian.JIRA>
In-Reply-To: <JIRA.12963761.1461907686000@Atlassian.JIRA>
References: <JIRA.12963761.1461907686000@Atlassian.JIRA> <JIRA.12963761.1461907686656@arcas>
Subject: [jira] [Commented] (CLIMATE-785) RCMED.py: Optimize code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 09 May 2016 22:15:20 -0000


    [ https://issues.apache.org/jira/browse/CLIMATE-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277176#comment-15277176 ] 

ASF GitHub Bot commented on CLIMATE-785:
----------------------------------------

Github user OCWJenkins commented on the pull request:

    https://github.com/apache/climate/pull/334#issuecomment-218006252
  
    Can one of the admins verify this patch?


> RCMED.py: Optimize code
> -----------------------
>
>                 Key: CLIMATE-785
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-785
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: data sources
>            Reporter: Ibrahim Jarif
>            Assignee: Ibrahim Jarif
>            Priority: Trivial
>              Labels: easyfix
>
> In ocw/data_source/rcmed.py file
> {code}
> if time_step.lower() == 'monthly':
>         if time.day != 1:
>             start_time_string = time.strftime('%Y%m%d')
>             start_time_string = start_time_string[:6] + '01'
>             time = datetime.strptime(start_time_string, '%Y%m%d')
>             ##TODO: Change the 3 lines above with this line:
>             ##time = datetime(time.year, time.month, 1)
>     elif time_step.lower() == 'daily':
>         if time.hour != 0 or time.minute != 0 or time.second != 0:
>             start_time_string = time.strftime('%Y%m%d%H%M%S')
>             start_time_string = start_time_string[:8] + '000000'	
>             time = datetime.strptime(start_time_string, '%Y%m%d%H%M%S')
>             ##TODO: Change the 3 lines above with this line:
>             ##time = datetime(time.year, time.month, time.day, 00, 00, 00)
> {code}
> The commented code can be used in place of the actual code.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)