climate-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MJJoyce <...@git.apache.org>
Subject [GitHub] climate pull request: CLIMATE-643 - Updating some of examples
Date Thu, 30 Jul 2015 17:22:03 GMT
Github user MJJoyce commented on the pull request:

    https://github.com/apache/climate/pull/210#issuecomment-126409195
  
    To give you an idea of what I'm talking about here @huikyole in case it's confusing. Here's
an example of how I would have broken these down into multiple tickets and their relevant
changes.
    
    New Ticket 1:
    This [new function](https://github.com/apache/climate/pull/210/files#diff-e41b7ee3c7e3b2339c964f6882ecfaa5R426)
would be here. 
    This [variable name update](https://github.com/apache/climate/pull/210/files#diff-e41b7ee3c7e3b2339c964f6882ecfaa5R409)
is related so we could include that as well.
    Tests for the new function would be included in a commit in here as well.
    
    New Ticket 2:
    Missing data [changes](https://github.com/apache/climate/pull/210/files#diff-e41b7ee3c7e3b2339c964f6882ecfaa5R463)
would fall in another ticket here.
    Tests for this new function would be here as well.
    
    New Ticket 3:
    [This is a propagation bug](https://github.com/apache/climate/pull/210/files#diff-e41b7ee3c7e3b2339c964f6882ecfaa5R463)
for the existing values and would be its own ticket.
    New test would be included in here as well so we don't miss this bug in the future!
    
    New Ticket 4:
    Any change in [the CLI app](https://github.com/apache/climate/pull/210/files#diff-9e183b82ea6b20fcfefa86ca818c670eR19)
that you have in here would be in another ticket.
    Would probably need to update tests if appropriate for the CLI (I'm not familiar w/ the
code so I'm unsure if that's the case)
    
    This ticket:
    The changes in [examples/knmi_to_cru31_full_bias.py](https://github.com/apache/climate/pull/210/files#diff-a84c6055f2eee6f83c3eac5d00e324d0R28)
would be in this ticket since it's the actual update to the example file.
    
    ---
    
    So, if these tickets build off of each other you would do something to the effect of:
    * Make feature branch off master for Ticket 1. Make changes, update tests, and make PR
    * Make feature branch off master for Ticket 2. Make changes, update tests, and make PR.
When we merge Ticket 1/2 we will need to rebase this but that should be fine. The changes
are obvious enough to make merging and issues easy/trivial.
    * Make feature branch for Ticket 3 off master. Make changes, write test, and make PR.
Will need to rebase here as well when we merge but see above. Should be easy.
    * Make feature branch for Ticket 4 off master. Etc.
    * Make feature branch for this ticket. You will probably need to merge some of the stuff
in the ticket 1, 2, and 3 feature branches in here so that way you have the changes that you
need. When we merge the others into master it's simple enough to rebase again and include
those relevant commits.
    
    ---
    
    Hopefully that helps. If you have questions let me know!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message